profanity-im
Replace libsignal-protocol-c with libomemo-c
The library libsignal-protocol-c is not maintained. This commit will replace the dependency libsignal-protocol-c with libomemo-c.
On 2025-02-07 a new version of protobuf-c has been uploaded to Debian. This new version induced a bug for libsignal-protocol-c and libomemo-c:
- Bug#1095352: libomemo-c: FTBFS [1]
- Bug#1095353: libsignal-protocol-c: FTBFS [2]
(Thanks to Dino team and Debian Maintainer it's solved)
libomemo-c [3] is a fork of libsignal-protocol-c [4] maintained by the Dino team.
[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095352 [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1095353 [3] https://github.com/dino/libomemo-c [4] https://github.com/signalapp/libsignal-protocol-c
Note: Commits squashed and commit message edited by @jubalh.
Received those patches via PM and mailinglist from Stefan.
Comments (to Stefan): I squashed the two commits into 1. If you use 2 commits then the configure change should have been done with the same commit as changing the source files. Since otherwise it wouldn't build ;) Then the CI changes could be a separate step.
Don't forget that we use present tense in commit messages (Replace not Replaced).
I also added the (quite valuable) info that you added to the email but not to the patch files themselves.
And CI sais no :)
@jubalh: Nice! :)
Can you help to update libomemo-c to latest XEP-0384 version?
- https://xmpp.org/extensions/xep-0384.html
At this time: 0.8.3 (2022-01-18).
Ticket here:
- https://github.com/dino/libomemo-c/issues/11
Note: @Ri0n from @psi-im team has done a PR here:
- https://github.com/dino/libomemo-c/pull/10
https://github.com/dino/libomemo-c/releases/tag/v0.5.1 has been released. It contains https://github.com/dino/libomemo-c/commit/bf9daf2a11083413874f915a0249f6b4ce761d54.
@jubalh: Thanks for 0.5.1:
- https://github.com/dino/libomemo-c/releases/tag/v0.5.1
cc: @Ri0n (@psi-im)