profanity icon indicating copy to clipboard operation
profanity copied to clipboard

`prof_post_chat_message_display` plugin hook for chat history messages is never invoked

Open ventosus opened this issue 11 months ago • 3 comments

The prof_post_chat_message_display hook is never invoked on the plugin side for chat history messages, only the prof_pre_chat_message_displayhook seems to be invoked.

debug

In the plugin hooks I just put this:

char msg [128];
snprintf(msg, sizeof(msg), "[%s] %s %s %s", __func__, barejid, resource, message);
prof_cons_show(msg);

log

14:42:33 ! [prof_pre_chat_message_display] peer@domain1 (null) ping
14:42:33 ! [prof_pre_chat_message_display] me@domain2 (null) pong
14:42:33 ! [prof_on_chat_win_focus] peer@domain1

version

$ profanity --version 2>&1 | sed -e 's/^/    /g'
Profanity, version 0.14.0
Copyright (C) 2012 - 2019 James Booth <[email protected]>.
Copyright (C) 2019 - 2023 Michael Vetter <[email protected]>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.24.1)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (3.13.1)
GTK icons/clipboard: Disabled
GDK Pixbuf: Enabled

ventosus avatar Jan 17 '25 14:01 ventosus

What do you mean by chat history messages? The limited history sent by the MUC? Or do you mean messages retrieved via MAM? MAM support isn't finished yet. Is named experimental in the documentation. And is being worked on here https://github.com/profanity-im/profanity/pull/1862

jubalh avatar Jan 17 '25 14:01 jubalh

What do you mean by chat history messages?

The limited history sent by the MUC?

No, messages from the SQLite log database.

ventosus avatar Jan 26 '25 19:01 ventosus

@ventosus I see there is a commit on your fork. Did you plan to open a PR?

jubalh avatar Aug 22 '25 06:08 jubalh