profanity icon indicating copy to clipboard operation
profanity copied to clipboard

Floating point exception

Open mdosch opened this issue 1 year ago • 6 comments

When running profanity through torsocks it often crashes with floating point exception. As other programs don't have this issue it seems to be related to profanity. I realized the log is alwas showing a message with a , when it happens. Maybe that's related and something is interpreted as float due to the comma.

2024-10-03T15:29:38.909759+02: xmpp: DBG: RECV: <iq id="pQ6HxcSRRwZT57Xf24ce3e1fc4520e8087323c582cd90975d09c3dd" to="REDACTED/profanity.&lt;3" lang="en" type="result" from="REDACTED"><pubsub xmlns="http://jabber.org/protocol/pubsub"><items node="eu.siacs.conversations.axolotl.bundles:519037298"><item id="current"><bundle xmlns="eu.siacs.conversations.axolotl"><signedPreKeyPublic signedPreKeyId="1">BfTsTAwtxnG8BZJknnZIidQU5cnwO/bam3toaFl5LQwP</signedPreKeyPublic><signedPreKeySignature>I5rjsL5c0sVFIgYkOQfUCxBpSvzAuFQFHZrYzQLhFeVE4OixQ3tb9OQsEXvYGPyvVOyNUEh3sCaM6JJBJgETgw==</signedPreKeySignature><identityKey>BTW/wOqibPC4nR/B84wUNamteEUvzKjSjzUI+zUT7aAV</identityKey><prekeys/></bundle></item></items></pubsub></iq>
2024-10-03T15:29:38.909803+02: prof: DBG: iq stanza handler fired
2024-10-03T15:29:38.909840+02: prof: DBG: [OMEMO] omemo_start_device_session_handle_bundle: REDACTED
2024-10-03T15:29:38.909858+02: prof: DBG: [OMEMO] omemo_start_device_session_handle_bundle: 519037298
2024-10-03T15:29:38.909881+02: prof: DBG: [OMEMO] Starting device session for REDACTED with device 519037298
2024-10-03T15:29:38.909908+02: prof: DBG: [OMEMO] cache identity for REDACTED:519037298: 35bfc0eaa26cf0b89d1fc1f38c1435a9ad78452fcca8d28f3508fb3513eda015
2024-10-03T15:29:38.917289+02: prof: DBG: [OMEMO][STORE] Checking trust REDACTED (519037298)
2024-10-03T15:29:38.917341+02: prof: DBG: [OMEMO][STORE] Checking trust REDACTED (519037298): 1
2024-10-03T15:29:38.917368+02: prof: DBG: [OMEMO] Trust REDACTED (519037298): 1
2024-10-03T15:29:38.917399+02: prof: DBG: [OMEMO][STORE] No Session for 519037298 
2024-10-03T15:29:38.917427+02: prof: DBG: [OMEMO] There is no Session for REDACTED ( 519037298) ,… building session.

Expected Behavior

Don't crash when running in torsocks.

Current Behavior

Crashes with floating point exception

Possible Solution

No idea.

Steps to Reproduce (for bugs)

  1. Run profanity in torsocks, e.g. torsocks -q profanity -a myacc -l DEBUG
  2. Use and wait.

Context

As it always stop with the same log messae with OMEMO stuff received from the same JID, I could ask the person whether they'd be ok to be contacted by profanity devs for debugging.

Environment

Debian Stable (Bookworm)

profanity -v
Profanity, version 0.14.0
Copyright (C) 2012 - 2019 James Booth <[email protected]>.
Copyright (C) 2019 - 2023 Michael Vetter <[email protected]>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.18.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (3.11.2)
GTK icons/clipboard: Enabled
GDK Pixbuf: Enabled
apt list -a libstrophe0
Auflistung… Fertig
libstrophe0/stable-backports,now 0.13.0-1~bpo12+1 amd64  [installiert]

mdosch avatar Oct 03 '24 13:10 mdosch

Also happens with freshly compiled profanity master:

profanity -v
Profanity, version 0.14.0dev.master.dce0b737
Copyright (C) 2012 - 2019 James Booth <[email protected]>.
Copyright (C) 2019 - 2024 Michael Vetter <[email protected]>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.18.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (3.11.2)
GTK icons/clipboard: Enabled
GDK Pixbuf: Enabled

mdosch avatar Oct 03 '24 13:10 mdosch

Seems like purging the JID in question from all files in ~/.local/share/profanity/omemo/me_at_myserver.de fixed it.

mdosch avatar Oct 03 '24 14:10 mdosch

Does this mean that a solution has been found that needs to be implemented or is this bug ready to be closed without a code change? (I don't know what a JID is in this context. Java ID or something like that?)

ProfessorTom avatar Jan 12 '25 22:01 ProfessorTom

FMU it's the third option: there seems to be a bug, but nobody investigated it deep enough to pinpoint the reason and the reporter has found a way to work around it.

JID = Jabber ID, the original term for "XMPP address"

sjaeckel avatar Jan 13 '25 07:01 sjaeckel

Hi, I noticed this issue and wanted to help. Currently I am running Profanity in WSL (Ubuntu) with torsocks on and I find no issue launching? I wanted to fix this bug (for class but also I think Tor and secure messaging is cool), however I'm having issues reproducing the bug. Anyone else make any progress?

OdenDillenkoffer avatar Feb 05 '25 21:02 OdenDillenkoffer

Hi @OdenDillenkoffer and welcome to Profanity! I heard from others they couldn't reproduce it too. So its a little a flanky bug.

I would suggest to look at one of our other issues, as we have plenty ;), and pick one of those. Cheers!

jubalh avatar Feb 06 '25 08:02 jubalh