profanity icon indicating copy to clipboard operation
profanity copied to clipboard

Profanity hangs, and segfaults when attempting to find mentions in an extremely long message

Open techmetx11 opened this issue 2 years ago • 1 comments

Expected Behavior

Profanity continues as normal

Current Behavior

Profanity hangs without drawing the message, and soon after, crashes

Possible Solution

Implement a size limit in the get_mentions function

Steps to Reproduce (for bugs)

  1. Send an extremely long message to someone using Profanity

Context

Environment

  • Operating System: Artix Linux (OpenRC)
  • glib: 2.72.3
Profanity, version 0.13.0dev.feature/1158-vcard.d259b9fe
Copyright (C) 2012 - 2019 James Booth <[email protected]>.
Copyright (C) 2019 - 2022 Michael Vetter <[email protected]>.
License GPLv3+: GNU GPL version 3 or later <https://www.gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Build information:
XMPP library: libstrophe
Desktop notification support: Enabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.18.0)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (3.10.7)
GTK icons/clipboard: Enabled
GDK Pixbuf: Enabled

techmetx11 avatar Sep 29 '22 21:09 techmetx11

I'll need to test this. Feel free to open a PR if you want to.

Implement a size limit in the get_mentions function

If we do that, we should make it configurable by the user.

jubalh avatar Sep 30 '22 07:09 jubalh

@techmetx11 are you in the mood to tackle this one?

jubalh avatar Mar 10 '23 10:03 jubalh