procrastinate icon indicating copy to clipboard operation
procrastinate copied to clipboard

Make _wrap_json methods public

Open denisSurkov opened this issue 2 months ago • 1 comments

This way wrap_json is easier to reuse.

This is simple proof of concept with Psycopg connector. If it looks okey, I will do the same with other connectors.

I don't want to place _wrap_json somewhere else. I think it is convenient to call it with context this is wrap json related to psycopg (or other connector).

Discussion: https://github.com/procrastinate-org/procrastinate/discussions/1479

Successful PR Checklist:

  • [x] Tests
    • [ ] (not applicable?)
  • [ ] Documentation
    • [ ] (not applicable?)

PR label(s):

  • [ ] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20breaking%20%F0%9F%92%A5
  • [x] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20feature%20%E2%AD%90%EF%B8%8F
  • [ ] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20bugfix%20%F0%9F%95%B5%EF%B8%8F
  • [ ] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20miscellaneous%20%F0%9F%91%BE
  • [ ] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20dependencies%20%F0%9F%A4%96
  • [ ] https://github.com/procrastinate-org/procrastinate/labels/PR%20type%3A%20documentation%20%F0%9F%93%9A

denisSurkov avatar Nov 09 '25 17:11 denisSurkov

@medihack , I made PoC with wrap_json. If it looks okey, I will do the same with other connectors.

denisSurkov avatar Nov 09 '25 17:11 denisSurkov