blueprinter icon indicating copy to clipboard operation
blueprinter copied to clipboard
verified publisher icon procore-oss

Feature: Discard nil value field

Open jamesst20 opened this issue 1 year ago • 1 comments

Closes https://github.com/procore-oss/blueprinter/issues/424

Checklist:

  • [OK] I have updated the necessary documentation
  • [OK] I have signed off all my commits as required by DCO
  • [OK] My build is green

jamesst20 avatar Jun 13 '24 14:06 jamesst20

Thank you for opening this and helping add some additional configurability to Blueprinter!

Most of my comments are primarily around naming, but happy to discuss further!

Thanks for the quick review! Very much appreciated. I have applied all of your recommandations, after all I don't know much about this project conventions so I will stick to yours :)

jamesst20 avatar Jun 18 '24 15:06 jamesst20

Hey @lessthanjacob

May I kindly bump this and ask what's the next step now that is has your approval?

jamesst20 avatar Jul 09 '24 22:07 jamesst20

Hey @jamesst20! I believe I may have suggested some changes to the tests that weren't totally valid syntax-wise. Do you mind addressing those locally and pushing up a fix? Apologies for that!

lessthanjacob avatar Jul 10 '24 14:07 lessthanjacob

@lessthanjacob It's done! :) Indeed there was an extra , at the end of a line

Capture d’écran, le 2024-07-10 à 11 05 26

jamesst20 avatar Jul 10 '24 15:07 jamesst20