processwire-issues icon indicating copy to clipboard operation
processwire-issues copied to clipboard

Required asterisk color

Open adrianbj opened this issue 3 months ago • 5 comments

When the page initially loads, it matches pw-main-color, but after it finishes loading, it changes to #FFEBEB

Recording shows it's initially final state - then you'll see the page reload where it turns green and then after the page has finished loading, it goes back to that pinky/red.

Image

adrianbj avatar Sep 22 '25 21:09 adrianbj

@adrianbj I can't replicate. I searched for FFEBEB and can't find it in any file. The original asterisk color is red, and with the Konkat style it's --pw-main-color.

matjazpotocnik avatar Sep 24 '25 18:09 matjazpotocnik

Thanks for taking a look @matjazpotocnik - turns out the issue is from @teppokoivula 's Version Control module: https://github.com/teppokoivula/VersionControl/blob/508592f8a6959c54e1c3d0333665b9b524319950/res/css/VersionControl.css#L144C1-L147C2

Even so, I don't really think PW should use pw-main-color for the required status indicator - I think red is probably the appropriate color on all sites. What do you think?

adrianbj avatar Sep 24 '25 19:09 adrianbj

@matjazpotocnik - also worth noting that the same css style appears in: /wire/modules/AdminTheme/AdminThemeUikit/uikit-pw/pw.min.css

which is still being loaded before the new konkat css file.

adrianbj avatar Sep 24 '25 22:09 adrianbj

Even so, I don't really think PW should use pw-main-color for the required status indicator - I think red is probably the appropriate color on all sites. What do you think?

I recently filled out an online booking form, and the asterisk was the same color as the text. More interesting, the nonmandatory fields were marked with an asterisk!

matjazpotocnik avatar Sep 25 '25 03:09 matjazpotocnik

I think having it the same color as the text would be fine. I just don't think the link color makes sense because it's not a link.

adrianbj avatar Sep 25 '25 04:09 adrianbj