Pink links in new theme

[adrianbj]

Even though I have set a custom color (which is applied in lots of places), the PW pink is being used for most links and other places like:

It's not even the same "pink" that is the red color from here:

It's actually defined here:

a, .uk-link {
    color: #e83561;
    text-decoration: none;
    cursor: pointer;
}

[adrianbj]

I also noticed that links within cards are underlined.

For the moment, I am fixing both with:

.uk-card :is(a, .uk-link) {
    text-decoration: none;
}

a {
    color: var(--pw-main-color);
}

[ryancramerdesign]

@adrianbj I can't find the a, .uk-link rule that you mentioned. Where does that appear? Or maybe it's already been changed?

[adrianbj]

@ryancramerdesign

https://github.com/processwire/processwire/blob/dev/wire/modules/AdminTheme/AdminThemeUikit/uikit-pw/pw.min.css

Look for a,.uk-link{color:#e83561;text-decoration:none;cursor:pointer}

[ryancramerdesign]

@adrianbj Okay, that's the core original theme file. Maybe a similar rule needs to be added to the Konkat default theme, like this?

a, .uk-link {
  color: var(--main-color); 
}

[adrianbj]

@ryancramerdesign - yeah, that's basically what I described above - for some reason the Konkat theme doesn't specify link colors at all and so everything falls back to the default. We do need to be careful here though - as I noted in my other recent issue, the use of !important in Konkat is also causing issues - feels like a very tangled web is being weaved at the moment.

[adrianbj]

@ryancramerdesign - please note that this also needs overriding/replacing:

.PageList .ProcessListerTable tr.open>td:first-child a.actions_toggle {
    color: #d21846;
}

It's not the same pink, but it still looks very out of place.

[romaincazier]

Was this changed recently?

I have two local installation, one on 3.0.248 and one on 3.0.251. On 3.0.248, the css:

a, .uk-link {
    color: var(--main-color); 
}

is there, but somehow it got lost in 3.0.251 (or maybe an earlier version?)

[matjazpotocnik]

yes, those lines were present in 3.0.250, but https://github.com/processwire/processwire/commit/96165bbff4569897422281dc1a25317873d556cc removed them

[ryancramerdesign]

I don't think that was intended to be removed. I will add back.

[matjazpotocnik]

@adrianbj @romaincazier this should be fixed in PW 3.0.252

[adrianbj]

@matjazpotocnik @ryancramerdesign - I'd still like to see that:

.uk-card :is(a, .uk-link) {
	text-decoration: underline;
}

which I also noted above either removed or changed to none (depending on what other CSS file might be leaking up (there are so many, it's hard to keep track of).

I don't think underlines are a thing in the PW in general, so not sure why elements inside cards should be underlined.