Deprecated: Passing E_USER_ERROR to trigger_error() is deprecated since 8.4, throw an exception or call exit with a string message instead in /pwtest.test/index.php on line 64

[adrianbj]

That's it really 😁

[adrianbj]

In case it helps:

Obviously the key issue is that the MySQL isn't available, but the deprecation should still be fixed.

[BernhardBaumrock]

@adrianbj I had this today and started an issue to collect all deprecations: https://github.com/processwire/processwire-issues/issues/2104

[adrianbj]

@ryancramerdesign - I had this again today - this time after a CSRF login error. I think my recent update (https://github.com/adrianbj/TracyDebugger/commit/1f2544b2db0b18f800e80f1e657b2a07e0c53ce3) to Tracy will mean this error will now happen every time there is a CSRF issue (which is actually relatively often when someone comes back to page after their session has timed out.

[adrianbj]

@ryancramerdesign - I see you are dealing with some deprecations today - any chance you could take a look at this one as well please and thanks.

[ryancramerdesign]

@adrianbj I've pushed an update to support this. It was not as simple as I would have liked, as there was a lot had to change, and it has to continue to support older versions of index.php at the same time. Also had to make sure it would continue to work with TD, as PHP's suggestions of swapping with an exit; wasn't going to work, nor would throwing more exceptions that may or may not be caught.

After messing with it quite a bit, I think I found a solution that'll work, still works with old index.php files, still works with Tracy, and hopefully doesn't break anything. It required changes across several files, so there may still be issues that haven't surfaced yet.

It's now passing through both Exception and Error objects to Tracy in the hooked $wire->trackException() method. Prior to this, I think Tracy was receiving only Exceptions this way, and receiving Errors through its shutdown handler in /Tracy/Debugger/Debugger.php file. But that won't work if we can't trigger E_USER_ERROR in PHP 8.4+, so had to add support for Throwables rather than just Exceptions, but it's probably for the best.

[adrianbj]

Thanks very much @ryancramerdesign - sorry that turned out to be so much work, but hopefully the improvements around Throwables. I have done some quick testing and everything looks good so far - especially the interactions with Tracy and allowing the:

            $this->wire()->addHookBefore('Wire::trackException', function($event) {
                $event->wire()->config->allowExceptions = true;
            });

hooks to do its job, when in development mode, so thank for paying attention to that.