processing-website icon indicating copy to clipboard operation
processing-website copied to clipboard
verified publisher icon processing

Fix: Search Input Placeholder Text Inconsistency

Open manascb1344 opened this issue 2 years ago • 1 comments

Issue

The placeholder text in the search input on the Processing website shows inconsistency. Initially, it displays 'Search,' but upon clicking the input box, it changes to 'Search with Google,' deviating from the expected behavior of consistently displaying 'Search with Google.'

Fixes Issue: #502

Changes Made

  1. Modified the id property for the search input to ensure the placeholder text remains 'Search with Google' both before and after clicking on the input box.

    • From: id: focused ? 'searchWithGoogle' : 'search'
    • To: id: 'searchWithGoogle'

  2. Updated the placeholder text in the code to reflect the expected behavior.

    • Changed "search": "Search" to "search": "Search with Google"
    • Changed "search": "Buscar" to "search": "Buscar con Google"

Test

Verified the changes by following the steps to reproduce the issue:

  1. Visit the Processing website.
  2. Locate the search bar in the navigation.
  3. Observed the placeholder text before and after clicking on the search input box.
  4. Verified that the placeholder text remains consistent as 'Search with Google' in both states.

Additional Notes

These changes address the placeholder text inconsistency and align the behavior with the expected outcome. The modified code ensures a better user experience on the Processing website by providing clear and consistent placeholder text in the search input.

Please review and merge these changes. If there are any concerns or questions, feel free to discuss them in the comments.

Attached a video demonstration showcasing the implemented changes. The demo illustrates the search input behavior confirming that the placeholder text now consistently displays 'Search with Google'.

https://github.com/processing/processing-website/assets/122693801/8502011e-fc92-4120-be7c-0751da2de157

manascb1344 avatar Jan 08 '24 17:01 manascb1344

Hey @SableRaf ! 🚀 Just wanted to bring your attention to a recent fix in PR #506 . Resolved an issue with placeholder text inconsistency in the Processing website's search input. Fixes issue: #502

manascb1344 avatar Jan 09 '24 18:01 manascb1344

Closing see: https://github.com/processing/processing-website/issues/509#issuecomment-2225431881

Stefterv avatar Jul 12 '24 12:07 Stefterv