p5.js icon indicating copy to clipboard operation
p5.js copied to clipboard

Add keycode fes warning

Open a-y-a-n-das opened this issue 1 month ago • 3 comments

Resolves #7876

Changes:

  • Added a one-time Friendly Error System (FES) warning for keyCode usage in src/core/main.js.
    • The warning informs users that keyCode is deprecated and suggests using keyIsDown() instead.
  • Added a manual test files: test/manual-test-examples/events/keyCode-warning.html and test/manual-test-examples/events/keyCode-warning-sketch.js
    • Verifies that the warning appears once and key behavior remains unchanged.

Screenshots of the change:

image

PR Checklist

a-y-a-n-das avatar Nov 07 '25 06:11 a-y-a-n-das

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! 🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure! 🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

welcome[bot] avatar Nov 07 '25 06:11 welcome[bot]

Hi! I realized I should’ve claimed this issue first (as per the contributing guidelines), but since it wasn’t assigned to anyone and was still open, I went ahead and fixed it. Hope that’s okay — please review when you get a chance. I can make any necessary adjustments if needed. 😊

a-y-a-n-das avatar Nov 07 '25 06:11 a-y-a-n-das

@ksen0, let me know if any changes are needed.

a-y-a-n-das avatar Dec 06 '25 04:12 a-y-a-n-das