p5.js icon indicating copy to clipboard operation
p5.js copied to clipboard

Adding missing examples to the documentation.

Open deveshidwivedi opened this issue 1 year ago • 7 comments

Resolves #6750

Changes: Added some of the missing examples.

Before:

Screenshot 2024-01-17 201617

After:

Screenshot 2024-01-20 000144

PR Checklist

deveshidwivedi avatar Jan 19 '24 18:01 deveshidwivedi

It looks like currently tests are failing from a linting error:

Running "eslint:source" (eslint) task
/home/runner/work/p5.js/p5.js/src/dom/dom.js:4664:72: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/webgl/p5.Geometry.js:310:16: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/webgl/p5.Geometry.js:311:16: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/webgl/p5.Geometry.js:329:53: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/webgl/p5.Geometry.js:944:59: Trailing spaces not allowed. [Error/no-trailing-spaces]
/home/runner/work/p5.js/p5.js/src/webgl/p5.Geometry.js:947:3: Trailing spaces not allowed. [Error/no-trailing-spaces]

(I haven't taken a closer look just yet at the changes, I'll do that soon. Thanks for taking on this task and adding so many examples!)

davepagurek avatar Jan 19 '24 18:01 davepagurek

I'll fix these..

deveshidwivedi avatar Jan 19 '24 19:01 deveshidwivedi

Thank you @deveshidwivedi for raising this point. It's essential for new learners who may struggle with understanding concepts without clear examples. Your examples are excellent. I'd like to add a few cleanup for this one. :)

perminder-17 avatar Jan 19 '24 20:01 perminder-17

Thank you!@perminder-17 Please share any suggestions for refinement you may have.

deveshidwivedi avatar Jan 19 '24 21:01 deveshidwivedi

Oops Idk why my review is not showing up, maybe due to the access. Sharing the screenshots though :')

review

review2

perminder-17 avatar Jan 19 '24 21:01 perminder-17

@perminder-17 You seem to have started the review but not submitted it, on the top right of the code review page you need to press "Review changes" > "Submit review" for it to show up.

limzykenneth avatar Jan 21 '24 12:01 limzykenneth

@perminder-17 You seem to have started the review but not submitted it, on the top right of the code review page you need to press "Review changes" > "Submit review" for it to show up.

Thanks... My bad😂

perminder-17 avatar Jan 21 '24 13:01 perminder-17