p5.js
p5.js copied to clipboard
Optimized 2D Primitives Test Suite: Bug Fixes and Validation Improvements
Resolves #6686
Changes:
-
p5.prototype.ellipse: Fixed missing parameters #2 and #3, resolving validation issues.
-
p5.prototype.rect: Handled missing parameter #5 to properly throw validation errors.
-
p5.prototype.square: Updated to handle missing parameter #3 appropriately.
-
p5.prototype.line: Fixed a bug where incorrect parameters did not trigger validation errors.
-
p5.prototype.triangle: Improved error messaging for better clarity.
PR Checklist:
- [ ]
npm run lint
passes - [ ] Inline documentation is included / updated
- [ ] Unit tests are included / updated
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!
It looks like this PR has added a lot of files, are those intentional? Do you mind looking through the diff of this PR and cleaning up the code to make sure only the changes you want are present in the diff?
@davepagurek ahh i think this bcs .history files alot added let me correct it
can u look now ?
There are still changes to package.json
and package-lock.json
which should not be committed here.