p5.js icon indicating copy to clipboard operation
p5.js copied to clipboard

Optimized 2D Primitives Test Suite: Bug Fixes and Validation Improvements

Open TanmayDhobale opened this issue 1 year ago • 5 comments

Resolves #6686

Changes:

  1. p5.prototype.ellipse: Fixed missing parameters #2 and #3, resolving validation issues.

  2. p5.prototype.rect: Handled missing parameter #5 to properly throw validation errors.

  3. p5.prototype.square: Updated to handle missing parameter #3 appropriately.

  4. p5.prototype.line: Fixed a bug where incorrect parameters did not trigger validation errors.

  5. p5.prototype.triangle: Improved error messaging for better clarity.

PR Checklist:

TanmayDhobale avatar Jan 04 '24 16:01 TanmayDhobale

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. And be sure to add yourself to the list of contributors on the readme page!

welcome[bot] avatar Jan 04 '24 16:01 welcome[bot]

It looks like this PR has added a lot of files, are those intentional? Do you mind looking through the diff of this PR and cleaning up the code to make sure only the changes you want are present in the diff?

davepagurek avatar Jan 05 '24 13:01 davepagurek

@davepagurek ahh i think this bcs .history files alot added let me correct it

TanmayDhobale avatar Jan 06 '24 04:01 TanmayDhobale

can u look now ?

TanmayDhobale avatar Jan 06 '24 06:01 TanmayDhobale

There are still changes to package.json and package-lock.json which should not be committed here.

limzykenneth avatar Jan 21 '24 11:01 limzykenneth