p5.js icon indicating copy to clipboard operation
p5.js copied to clipboard

Replace console.error with friendly error system

Open shashank-iitbhu opened this issue 1 year ago • 8 comments
trafficstars

Increasing Access

Many functions inside src/webgl and lib/addons currently uses console.error to report errors. It would be more user-friendly and consistent with the p5.js environment to replace these calls with the friendly error system (FES).

Most appropriate sub-area of p5.js?

  • [X] Accessibility
  • [ ] Color
  • [ ] Core/Environment/Rendering
  • [ ] Data
  • [ ] DOM
  • [ ] Events
  • [ ] Image
  • [ ] IO
  • [ ] Math
  • [ ] Typography
  • [ ] Utilities
  • [X] WebGL
  • [ ] Build Process
  • [ ] Unit Testing
  • [ ] Internalization
  • [X] Friendly Errors
  • [ ] Other (specify if possible)

Feature enhancement details

For example, take parseASCIISTL function in webgl/loading.js, I have triggered an error condition and the results,
with console.error: Screenshot 2023-12-13 at 10 41 06 PM
with FES: Screenshot 2023-12-13 at 10 42 01 PM It would be more user-friendly and consistent with the p5.js environment to replace these calls with the friendly error system (FES).

shashank-iitbhu avatar Dec 13 '23 17:12 shashank-iitbhu

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

welcome[bot] avatar Dec 13 '23 17:12 welcome[bot]

related PRs and Issues: #6098 and #5649 .

shashank-iitbhu avatar Dec 13 '23 17:12 shashank-iitbhu

@davepagurek if you can review this. I am willing to work on this issue. Please assign.

shashank-iitbhu avatar Dec 13 '23 17:12 shashank-iitbhu

can I get to work on this issue? this will be my first contribution in processing community

ranjanmangla1 avatar Dec 19 '23 22:12 ranjanmangla1

where to find this issue I forked the code base in local system??

omsharma29 avatar Dec 21 '23 07:12 omsharma29

Do we also have to change the throw new error keywords or only the console.error

samrudh3125 avatar Dec 30 '23 08:12 samrudh3125

@shashank-iitbhu please accept the pull request

samrudh3125 avatar Dec 30 '23 16:12 samrudh3125

@davepagurek Hey I would like to work on this issue. Can you assign me?

vaishnavi192 avatar Jan 28 '24 12:01 vaishnavi192