p5.js icon indicating copy to clipboard operation
p5.js copied to clipboard

Add missing accessibility description to p5.Color._parseInputs()

Open Zearin opened this issue 3 years ago • 1 comments

Most appropriate sub-area of p5.js?

  • [X] Accessibility (Web Accessibility)
  • [ ] Build tools and processes
  • [ ] Color
  • [ ] Core/Environment/Rendering
  • [ ] Data
  • [ ] DOM
  • [ ] Events
  • [ ] Friendly error system
  • [ ] Image
  • [ ] IO (Input/Output)
  • [ ] Localization
  • [ ] Math
  • [ ] Unit Testing
  • [ ] Typography
  • [ ] Utilities
  • [ ] WebGL
  • [ ] Other (specify if possible)

p5.js version

1.4.0

Web browser and version

No response

Operating System

No response

Steps to reproduce this

I was asked by @lm-n to open an Issue regarding a missing accessibility description to p5.Color._parseInputs().

Even though it’s a private function, I asked @lm-n if it still needed a describe(). His response:

doesn't matter for reference but could be helpful for contributors to see an example

Which works well enough for me! 👍

Zearin avatar Jan 30 '22 21:01 Zearin

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

welcome[bot] avatar Jan 30 '22 21:01 welcome[bot]

Hi @nickmcintyre, just checking in with you to see if we have this resolved in our recent effort of updating p5.js reference page. Thank you!

Qianqianye avatar Oct 12 '23 03:10 Qianqianye

@Qianqianye thanks for including me! This issue wasn't resolved in the first batch of edits. I don't think this method is actually "missing" an accessibility description. It isn't part of the public API and is only called internally.

As for adding an example to the reference, @paulaxisabel, @SoundaryaKoutharapu, @mrbrack, @TJ723, @Zarkv, @SkylerW99, @ramya202000, @hannahvy, @robin-haxx, @hiddenenigma I think y'all are better positioned to weigh in.

nickmcintyre avatar Oct 13 '23 20:10 nickmcintyre

It will just be an internal reference so I think adding an example won't be necessary for this case?

limzykenneth avatar Oct 22 '23 20:10 limzykenneth