p5.js-website icon indicating copy to clipboard operation
p5.js-website copied to clipboard

Adding a pause/play button for carousel

Open pcgamer1 opened this issue 5 years ago • 8 comments

Actual Behaviour Image carousel changes images without user's control.

Expected Behavior For Screen Readers, we can add a pause play button using Bootstrap Screen Reader functionality to avoid seizures. @limzykenneth Any suggestions or views?

Would you like to work on the issue? Yes

pcgamer1 avatar Mar 28 '20 08:03 pcgamer1

Where is this image carousel?

limzykenneth avatar Mar 28 '20 13:03 limzykenneth

@limzykenneth On the Donate page.

pcgamer1 avatar Mar 28 '20 13:03 pcgamer1

@limzykenneth Please review if you are free.

pcgamer1 avatar Mar 29 '20 07:03 pcgamer1

I think adding bootstrap it a bit too much, the transition can just be coded up in a couple lines of CSS with transition.

limzykenneth avatar Mar 29 '20 13:03 limzykenneth

@limzykenneth I meant that I will use CSS for the transitions. Just for the screen reader custom styling class I mentioned Bootstrap. I can do that manually as well. The buttons and the transitions will be added using CSS, just to make them visible only to screen readers, we can use Bootstrap. It's up to you if we should use Bootstrap or not. It provides a hiding class for screen readers i.e. sr-only which can be used for custom styling. I can start working on this without Bootstrap as well. I will then have to create an accessible hiding class for custom styling.

pcgamer1 avatar Mar 29 '20 13:03 pcgamer1

@limzykenneth I was not talking about transitions in this issue. I talked about pause/play button. I have talked about transitions in another issue. There is another issue regarding the search bar which I would like you to review.

pcgamer1 avatar Mar 29 '20 13:03 pcgamer1

Could instead of a slideshow, a screen reader just get a series of images? Then the screen reader can just skip to the next section if the user doesn't want to know what the images are about while users who do don't have to click on any button to know about the next image.

limzykenneth avatar Mar 30 '20 20:03 limzykenneth

@limzykenneth Yes we can do that. We will make input buttons using a specific class for screen reader so that the screen reader first asks the user whether he/she wants to know about the images or not. Then it will read/skip accordingly. I can start working on this.

pcgamer1 avatar Mar 31 '20 06:03 pcgamer1