p5.js-website icon indicating copy to clipboard operation
p5.js-website copied to clipboard

added vertical margin to nav items

Open whoisveroniica opened this issue 1 year ago • 1 comments

Resolves #612 by adding vertical margin to navigation items.

Margin value was picked to match jump to section margin value, mentioned in the issue.

Branch cotaines one failing test although, it also occurs in the main branch. So I decided to leave it as-is.

Below I attached screenshots showing before and after.

Desktop before Desktop after
p5 - original p5 - padding
Mobile before Mobile after
p5mobile - original p5mobile - padding

whoisveroniica avatar Nov 12 '24 19:11 whoisveroniica

Somewhere we have a breakpoint adding a min-height to the main nav so that when the window height is small, we don't get scroll bars on the main nav, just on the section nav below it. Do we need to update that min height here too? Currently I believe it's 350px, might need to be increased.

davepagurek avatar Nov 19 '24 15:11 davepagurek