p5.js-website icon indicating copy to clipboard operation
p5.js-website copied to clipboard

Main navigation items are squeezed together

Open whoisveroniica opened this issue 1 year ago • 5 comments

Increasing Access

Improves navigation accessibility.

Most appropriate sub-area of p5.js?

Navigation

Feature request details

Hi folks👋🏻 This is my very first contribution, so feedback is more than welcome! ❤️

I noticed items in the main navigation (as well as in a footer) are pretty squeezed together. It could negatively impact user experience, especially on mobile devices without precise pointers and lead to clicking an undesired link.

Screenshot of the main navigation items: Screenshot of the main navigation items

Solution to this issue would be adding more padding between each item, similarily to jump to section:

p5js org_examples_ (2)

whoisveroniica avatar Oct 19 '24 20:10 whoisveroniica

I'm generally in favor of giving these a bit of spacing and there are some general spacing issue elsewhere on the site but probably need a more coordinated approach to solve this though.

limzykenneth avatar Oct 25 '24 11:10 limzykenneth

@limzykenneth Thanks for your feedback!

but probably need a more coordinated approach to solve this though

What more coordinated approach do you have in mind, could you elaborate a little bit on that?

I've tried to fix the issue in #633. Let me know what you think of the current solution, thanks!

whoisveroniica avatar Nov 12 '24 20:11 whoisveroniica

Mainly that this is not the only place where spacing is an issue, so we probably need a more thorough review of spacing and see if a more consolidated solution can help solve all if not most of the spacing issues we have.

limzykenneth avatar Nov 12 '24 20:11 limzykenneth

@limzykenneth in the mean time, it looks like #633 makes the margins in the main nav match the margins in the section nav below (10px margin on items) so I think I'm ok doing the change to just the main nav for now to be consistent.

davepagurek avatar Nov 19 '24 15:11 davepagurek

@davepagurek We can merge #633 for now if needed until we have more time to review the rest of the spacing issues.

limzykenneth avatar Nov 19 '24 16:11 limzykenneth