p5.js-website icon indicating copy to clipboard operation
p5.js-website copied to clipboard

Issue editing code

Open marjavkass opened this issue 5 years ago • 17 comments

When I type into the code on https://p5js.org/examples/input-keyboard.html, the screen moves up and the code is no longer visible.

marjavkass avatar Feb 25 '19 23:02 marjavkass

@funkort I'm not able to replicate this problem on my side. Can you provide some more details about your system? Your OS and also your browser + version? Thanks.

limzykenneth avatar Feb 26 '19 10:02 limzykenneth

@funkort I am also facing the same issue. Whenever I type something or press enter, the screen moves up; however, if I press backspace it doesn't move up.

shubhi2000 avatar Mar 10 '19 19:03 shubhi2000

I am seeing this on Windows 10, under Google Chrome Version 72.0.3626.121 (Official Build) (64-bit)

takyano avatar Mar 11 '19 20:03 takyano

Hey all, do you have auto-save enabled? If so, when you disable auto-save does the issue go away? And in that case, does saving jump the editor to the top of the page?

meiamsome avatar Mar 11 '19 22:03 meiamsome

What auto-save option?

takyano avatar Mar 12 '19 01:03 takyano

Which auto-save option you are referring to? I am unable to find any auto-save option there. Can you please tell where is that option?

On Tue, Mar 12, 2019 at 7:28 AM takyano [email protected] wrote:

What auto-save option?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/processing/p5.js-website/issues/404#issuecomment-471817730, or mute the thread https://github.com/notifications/unsubscribe-auth/AsdXvbEIObO_KYSD1dcpmj2SfrF3U5_Gks5vVwm4gaJpZM4bRBd0 .

shubhi2000 avatar Mar 13 '19 01:03 shubhi2000

@takyano @shubhi2000 There is a cog symbol at the upper right of the page for settings and within that you will find the auto-save option.

meiamsome avatar Mar 13 '19 01:03 meiamsome

The symbol isn't there on my page.

On Wed, Mar 13, 2019 at 6:36 AM Oliver Wright [email protected] wrote:

@takyano https://github.com/takyano @shubhi2000 https://github.com/shubhi2000 There is a cog symbol at the upper right of the page for settings and within that you will find the auto-save option.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/processing/p5.js-website/issues/404#issuecomment-472239827, or mute the thread https://github.com/notifications/unsubscribe-auth/AsdXvaHrNgBdn4SdaoDAMB5D9pwru30uks5vWE8NgaJpZM4bRBd0 .

shubhi2000 avatar Mar 13 '19 01:03 shubhi2000

Oh, my apologies, I completely thought this was a different repository... that's my bad!

meiamsome avatar Mar 13 '19 01:03 meiamsome

@takyano Can you try a different browser to see if this is a browser specific issue? I don't have a Windows machine so I can't test this out myself.

@shubhi2000 Are you on the same kind of setup as @takyano?

limzykenneth avatar Mar 15 '19 13:03 limzykenneth

Edge doesn't have the jumping page problem. Microsoft Edge 44.17763.1.0

takyano avatar Mar 17 '19 09:03 takyano

Can confirm issue does not appear on Ubuntu 18.04 on both Chrome and FF latest.

GaurangTandon avatar Mar 18 '19 12:03 GaurangTandon

@takyano Do you have any extensions installed on your Chrome? If so can you try turning them off and see if the problem still persist?

limzykenneth avatar Mar 18 '19 12:03 limzykenneth

Google Chrome Version 73.0.3683.75 (Official Build) (64-bit)

Turned off all extensions and restarted Chrome.

If I open the Keyboard page from the Examples page into the same tab, I get the Page Jump behavior and this message in the console:

ace.js:1 [Violation] Added non-passive event listener to a scroll-blocking 'mousewheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
t.addListener @ ace.js:1
t.addMouseWheelListener @ ace.js:1
l @ ace.js:1
b @ ace.js:1
t.edit @ ace.js:1
init @ examples.js:6
(anonymous) @ examples.js:183

If I open the Keyboard page from the Examples page into a new tab, I do not get the Page Jump behavior.

If I refresh the non-jumping Keyboard page I get the Page Jump behavior and error message again.

takyano avatar Mar 19 '19 05:03 takyano

@takyano The message seems to just be a performance related warning and should not have caused this behaviour.

Honestly, this is pretty weird behaviour and I'm not sure what it could be. If you can hunt down where the problem stem from, even generally, it can really help. In the meantime I'll see if I can get a hold of a Windows machine to test this out.

limzykenneth avatar Mar 19 '19 11:03 limzykenneth

Tried editing a example page on Firefox 66.0.3(64-bit) under Windows 10 and the pages jumps up like under Google Chrome.

takyano avatar Apr 26 '19 07:04 takyano

@limzykenneth The Ace Editor libraries are out of date. I built the website and replaced the /assets/js/vendor/ace and /assets/js/vendor/ace-nc folders with a more recent version of the ace libraries.

This setup did not have the jumping problem.

takyano avatar Apr 29 '19 03:04 takyano