version.json doubts

[montoyamoraga]

hi! working with @guillemontecinos, we are following the steps of the README.md and step 3 mentions creating the version.json file.

We are currently just copying and pasting the file version-sample.json and then changing its name to version.json, is that OK?

Also, the version.json mentions p5.js version 0.6.0 and we are currently on 0.7.2., should we update it on the version-sample.json file directly? Or in the version.json? Or is it irrelevant? Or automatic?

I'm tagging @limzykenneth because I think they know the answer, best! =)

[limzykenneth]

I have never done that step as I think it's only used to show the version number and date on the download page. The live site probably generate version.json somehow as the version number on the live site is correct.

I would personally like to eliminate that step entirely to get closer to being able to just run rm -rf dist/ and the build step can still generate all the necessary files for the website.

[montoyamoraga]

thanks! i think i get it, so I won't touch the version-sample.json file in the meantime, I will leave this issue open if it's not a problem

[lmccart]

@montoyamoraga this file is .gitignored, so any data in here is fine, it will not get copied to the server. running the endpoint https://p5js.org/git-pull.php updates this file on the server, updating the version number from the github repo

[lmccart]

this should probably be documented in the readme, so let's leave this open until I can do that

[Guirdo]

Hola @holomorfo , este PR esta listo para ser revisado

[Guirdo]

Hello @Qianqianye @limzykenneth ! This PR is ready!

Thank you!

[Qianqianye]

Hi @Guirdo @holomorfo, could you fix the PR so it could pass the check? Thanks!

[Guirdo]

@Qianqianye Done!

[Qianqianye]

Looks great, thanks!