p5.js-website
p5.js-website copied to clipboard
Add p5.accessibility in [p5 examples](https://p5js.org/examples/)
Add p5.accessibility in p5 examples
@lm-n @MathuraMG I just tested with adding this module in and it seems to work fine. however, I realized we probably need some sort of interface for toggling the different outputs. do you have any recommendations for best practices here? that is, do offscreen buttons do the trick or should they be visible to all? is there a typical section heading and title for these buttons to use?
I think a hidden toggle should do the trick. We might just add a hidden "turn on accessible output" toggle before the canvas @MathuraMG what do you think?
@lm-n @lmccart That sounds good!
Turn on accessible output would toggle on which type? Or do you want a radio toggle between the three types and a fourth "off" option? @MathuraMG
@MathuraMG and I talked with Claire about this last week and discussed that perhaps we could add a toggle to turn on/off "text output" before the canvas. It could work like the "run button" if the buttons were before the canvas in the html structure.
@lmccart , yes that would be perfect, that way we can ensure that it is of the same importance as the run button
@MathuraMG @lm-n thanks! hoping to get this one done this week for your review
hi @MathuraMG @lm-n can you tell me technically how to toggle it on and off? do I show/hide the element?
Hi you two, I made some progress and am able to get some text output, you can see my changes in the access branch
However, I'm getting these errors with the p5-accessibilty script for some examples. Try this one for example.
I also wasn't sure how to toggle off the output once it's on.
Do you two want to try pulling down the access branch and seeing if you can work with it? The diffs in the most recent commit should point you to all the relevant places to insert code.
@lmccart - yes we will have a look and get back to you! Thank you so much
@lmccart - the reason for the above error is that the library handles only 100 objects, because beyond this it becomes super slow (and completely pointless) For instance, if we change num to 20 in the above example, the library works.
We will add some rules in the library so that it handles situations like this properly. Will update you once that is done.
@lm-n
@lmccart @cleezyITP @kjhollen @outofambit We should look into this issue!
merging this because code changes are so minimal