p5.js-website icon indicating copy to clipboard operation
p5.js-website copied to clipboard

Add p5.accessibility in [p5 examples](https://p5js.org/examples/)

Open lm-n opened this issue 6 years ago • 12 comments

Add p5.accessibility in p5 examples

lm-n avatar Jun 05 '18 16:06 lm-n

@lm-n @MathuraMG I just tested with adding this module in and it seems to work fine. however, I realized we probably need some sort of interface for toggling the different outputs. do you have any recommendations for best practices here? that is, do offscreen buttons do the trick or should they be visible to all? is there a typical section heading and title for these buttons to use?

lmccart avatar Jun 15 '18 23:06 lmccart

I think a hidden toggle should do the trick. We might just add a hidden "turn on accessible output" toggle before the canvas @MathuraMG what do you think?

lm-n avatar Jun 17 '18 20:06 lm-n

@lm-n @lmccart That sounds good!

MathuraMG avatar Jun 19 '18 01:06 MathuraMG

Turn on accessible output would toggle on which type? Or do you want a radio toggle between the three types and a fourth "off" option? @MathuraMG

lmccart avatar Jun 19 '18 01:06 lmccart

@MathuraMG and I talked with Claire about this last week and discussed that perhaps we could add a toggle to turn on/off "text output" before the canvas. It could work like the "run button" if the buttons were before the canvas in the html structure.

lm-n avatar Jun 26 '18 00:06 lm-n

@lmccart , yes that would be perfect, that way we can ensure that it is of the same importance as the run button

MathuraMG avatar Jul 05 '18 23:07 MathuraMG

@MathuraMG @lm-n thanks! hoping to get this one done this week for your review

lmccart avatar Jul 11 '18 23:07 lmccart

hi @MathuraMG @lm-n can you tell me technically how to toggle it on and off? do I show/hide the element?

lmccart avatar Jul 24 '18 02:07 lmccart

Hi you two, I made some progress and am able to get some text output, you can see my changes in the access branch

However, I'm getting these errors with the p5-accessibilty script for some examples. Try this one for example. screen shot 2018-07-23 at 8 06 27 pm

I also wasn't sure how to toggle off the output once it's on.

Do you two want to try pulling down the access branch and seeing if you can work with it? The diffs in the most recent commit should point you to all the relevant places to insert code.

lmccart avatar Jul 24 '18 03:07 lmccart

@lmccart - yes we will have a look and get back to you! Thank you so much

MathuraMG avatar Jul 24 '18 13:07 MathuraMG

@lmccart - the reason for the above error is that the library handles only 100 objects, because beyond this it becomes super slow (and completely pointless) For instance, if we change num to 20 in the above example, the library works.

We will add some rules in the library so that it handles situations like this properly. Will update you once that is done.

@lm-n

MathuraMG avatar Jul 31 '18 13:07 MathuraMG

@lmccart @cleezyITP @kjhollen @outofambit We should look into this issue!

lm-n avatar Aug 14 '19 21:08 lm-n

merging this because code changes are so minimal

outofambit avatar Apr 22 '24 23:04 outofambit