p5.js-website icon indicating copy to clipboard operation
p5.js-website copied to clipboard

3d basics tutorial

Open aceslowman opened this issue 3 years ago • 4 comments

Changes: In the process of adding a "Getting Started in 3d" tutorial to the learn page. This tutorial would introduce new coders to basic 3d terminology and concepts, walking through setup, transformations, lighting and materials.

(This draft pull request is so @kjhollen can provide some feedback for my GSOC project.)

aceslowman avatar Aug 30 '22 17:08 aceslowman

@kjhollen @limzykenneth I just added i18n tags for the custom geometry tutorial, am I going about this correctly? There are code comments that will need tags as well, but just wanting to confirm before continuing.

aceslowman avatar Sep 20 '22 22:09 aceslowman

Should be near completion! @limzykenneth I had one question, I have created the tags for the tutorials in the en.yml file for i18n, should I copy those tags over as placeholders to the other language files?

aceslowman avatar Oct 09 '22 16:10 aceslowman

@aceslowman That may not be necessary. If you can run npm test to completion it should be fine.

limzykenneth avatar Oct 11 '22 12:10 limzykenneth

@aceslowman That may not be necessary. If you can run npm test to completion it should be fine.

Just tested, npm test ran without issues, but the Learn page shows empty entries on all but the en site.

p5Capture

and within the pages there are only empty elements.

aceslowman avatar Oct 11 '22 22:10 aceslowman

In that case I think you would need to copy over the placeholder entries to the other languages (ie. untranslated entries).

limzykenneth avatar Oct 18 '22 15:10 limzykenneth

Thanks @limzykenneth! @aceslowman once you add in the translation placeholders for the other pages, let's upgrade this "draft" to a full PR so we can get it merged!

kjhollen avatar Oct 18 '22 19:10 kjhollen

@kjhollen Done! Just added tags to each translation file.

aceslowman avatar Oct 19 '22 20:10 aceslowman