p5.js-website icon indicating copy to clipboard operation
p5.js-website copied to clipboard

Published 20 hours ago • verified publisher icon processing

Broken Image link

Open tushar5526 opened this issue 3 years ago • 2 comments

Most appropriate sections of the p5.js website?

Reference

What is your operating system?

Linux

Web browser and version

Google Chrome 103.0.5060.134 (Official Build) (64-bit)

Actual Behavior

The reference image for 4 * 4 matrix is broken here applyMatrix

Expected Behavior

It should not be broken

Steps to reproduce

Visit this applyMatrix

Would you like to work on the issue?

No

tushar5526 avatar Jul 26 '22 13:07 tushar5526

Thanks @tushar5526! It's currently fixed in this commit. The image is now back on the page.

But I noticed that the example code for applyMatrix is not showing, wondering if @Gaweph @limzykenneth could share some thoughts on this since you worked on this PR. We can also discuss the reference asset system between the p5.js website and p5.js repos. Thanks!

Qianqianye avatar Jul 26 '22 21:07 Qianqianye

https://github.com/processing/p5.js/pull/5738 Should fix the example problem.

For assets, it would be great to consolidate all website assets (all pages, examples, and reference) to one place, even if putting some in relevant subfolders such as a examples or reference folder is necessary. Reducing duplicates can also help with reducing the overall size of this repo and how long it takes to clone, I'm tempted to suggest symlinks in some cases but it probably won't play well with a variety of things so I'm not opening that can of worms yet.

limzykenneth avatar Jul 29 '22 00:07 limzykenneth

Thanks @limzykenneth. The page https://p5js.org/reference/#/p5/applyMatrix is all fixed now in the recent 1.5.0 release.

Qianqianye avatar Oct 20 '22 19:10 Qianqianye