p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Made the Logo of P5 redirect to users sketches, Fixes #3083

Open sriganeshres opened this issue 10 months ago • 3 comments

Fixes #3083

https://github.com/processing/p5.js-web-editor/assets/120654479/2ae8c559-3a70-47cc-94b0-0d717b86e989

Changes:

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] has no test errors (npm run test)
  • [x] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [x] is descriptively named and links to an issue number, i.e. Fixes #3083

sriganeshres avatar Apr 21 '24 21:04 sriganeshres

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

welcome[bot] avatar Apr 21 '24 21:04 welcome[bot]

Release Environments

This Environment is provided by Release, learn more! To see the status of the Environment click on Environment Status below.

:wrench:Environment Status : https://app.release.com/public/Processing%20Foundation/env-b2eb0472ac

release-com[bot] avatar Apr 21 '24 21:04 release-com[bot]

Thanks for opening this PR!

I feel like it looks good so far! One extra change I might make is that the aria-label should be updated to indicate that this logo redirects to a user's sketch. I think it could help to try to do some screen reader testing here too to confirm this!

raclim avatar Apr 23 '24 21:04 raclim

Due to the amount of time that's passed, I'm going to close this PR for now, but please feel free to reopen a new one with the requested changes, thanks!

raclim avatar Jun 03 '24 00:06 raclim