p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

issues#3043| Adding Shortcut key for Creating new File, Creating new …

Open SOUMITRO-SAHA opened this issue 1 year ago • 1 comments

…Folder

Fixes #3043

Currently, I've added shortcuts for:

  • Adding a file: Alt + N
  • Adding a folder: Shift + Alt + N

To implement the other two, I require further clarification on:

  • Opening a new file
  • Opening my sketches

https://github.com/processing/p5.js-web-editor/assets/68202064/5bcf1ce0-754b-4d5d-a4e4-d0e60cf7dd8e

Changes:

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] has no test errors (npm run test)
  • [x] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [x] is descriptively named and links to an issue number, i.e. Fixes #123

SOUMITRO-SAHA avatar Mar 06 '24 14:03 SOUMITRO-SAHA

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

welcome[bot] avatar Mar 06 '24 14:03 welcome[bot]

Thanks for your contribution!

We do currently have a PR (https://github.com/processing/p5.js-web-editor/pull/2395) that addresses adding a new file that has been in progress. I'm sorry that it wasn't clarified at the time, but to avoid having too many shortcuts that might feel overwhelming (https://github.com/processing/p5.js-web-editor/issues/1292#issuecomment-608078511) think we still need further discussion to decide which specific actions we want to add shortcuts to.

Since we have quite a lot of PRs at the moment I'm going to close this one for now. I'm sorry that we aren't able to get this in at the moment, but please feel free to revisit or reopen this when the other shortcuts have been determined and fleshed out, thanks!

raclim avatar Mar 29 '24 13:03 raclim