p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Published 20 hours ago • verified publisher icon processing

Added eye icon

Open perminder-17 opened this issue 1 year ago • 8 comments

Fixes #2466

Changes: I have made the eye icon which is very helpful. here's how it works

https://github.com/processing/p5.js-web-editor/assets/127239756/9e3126e3-eb5b-474b-8025-36c07afcb0bb

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] has no test errors (npm run test)
  • [x] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [x] is descriptively named and links to an issue number, i.e. Fixes #123

perminder-17 avatar Sep 21 '23 23:09 perminder-17

Hi @lindapaiste can u please review the pull request.

perminder-17 avatar Sep 22 '23 00:09 perminder-17

@raclim @lindapaiste can this be merged or should I change something

perminder-17 avatar Oct 10 '23 08:10 perminder-17

I have tested the changes for microsoft edge too. @lindapaiste @raclim

perminder-17 avatar Oct 27 '23 16:10 perminder-17

Looks good to me, also working demo seems pretty fine!

Thankyou so much.

perminder-17 avatar Oct 29 '23 17:10 perminder-17

@lindapaiste Can we merge this PR? Or shall work on it's design? if Yes, can you please tell me what kind of design should i go with?

perminder-17 avatar Dec 12 '23 00:12 perminder-17

I think this eye icon looks bette than the other "hide" "show" pull request @raclim

katiejliu avatar Apr 12 '24 16:04 katiejliu

I think one issue I'm finding here is that the eye icon shifts when the error message for the form appears!

Screenshot 2024-04-12 at 11 33 07 AM

I haven't thought this through yet, but I'm wondering if it'd be better to either move the styles within the LoginForm.jsx and SignupForm.jsx file into a separate one, or to convert it into a styled-component?

raclim avatar Apr 12 '24 18:04 raclim

Sorry for the delay, I'll git it done very soon @raclim

perminder-17 avatar Apr 25 '24 17:04 perminder-17

I will be making a commit by june 6th. And will update what's required here.

perminder-17 avatar Jun 03 '24 18:06 perminder-17

https://github.com/processing/p5.js-web-editor/assets/127239756/b7f5d518-af60-4412-9086-26286a1efda0

so sorry for being too late @raclim . I was busy with my university exams and GSOC work, happily I got some time to shift styles to seperate one. also fixed the issue which was arising.

perminder-17 avatar Jun 06 '24 21:06 perminder-17

Hahahhaa no worries @raclim . I love to contribute and will surely contribute in this awesome organization with these awesome Mentainers like you❤

perminder-17 avatar Jun 12 '24 13:06 perminder-17