p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Published 20 hours ago • verified publisher icon processing

Fix empty project download

Open dwight9339 opened this issue 2 years ago • 1 comments

Fixes #2038

Changes: Updated buildZip and bundleExternalLibs functions in projects controller.

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] has no test errors (npm run test)
  • [x] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [x] is descriptively named and links to an issue number, i.e. Fixes #123

dwight9339 avatar Aug 04 '22 16:08 dwight9339

The solution works locally on my machine but fails in CI due to peer dependency errors. Can anyone help me with this so we can get this merged? Thanks

dwight9339 avatar Aug 04 '22 16:08 dwight9339

I don't see the dependency issues you described; it appears to be working and passed the tests and linting! Thank you so much for your work! :)

raclim avatar Oct 19 '22 19:10 raclim