p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

use react-redux hooks in Toast component

Open lindapaiste opened this issue 2 years ago • 2 comments

Related to issues #1458 & #2042

Changes:

  • Refactor the Toast component to use react-redux hooks instead of the connect HOC, in line with Redux best practices.
  • Handle the isVisible check inside of the Toast component itself instead of in the parent. This means that we only need one if instead of three, and the parents no longer need to access any toast state from the store.

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] has no test errors (npm run test)
  • [x] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [x] is descriptively named and links to an issue number, i.e. Fixes #123

lindapaiste avatar Jul 19 '22 05:07 lindapaiste

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

welcome[bot] avatar Jul 19 '22 05:07 welcome[bot]

Release Environments

This pull request environment is provided by Release, learn more! To see the status of the environment click on Environment Status below.

  • p5.js-web-editor

:wrench:Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-67f58d76b5

release-com[bot] avatar Aug 02 '22 05:08 release-com[bot]