p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Chore/react deprecation warnings

Open catarak opened this issue 2 years ago • 1 comments

Fixes #2021

Changes: Removes many of the React deprecation warnings. The rest of the warnings can be removed when upgrading to React 18.

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] has no test errors (npm run test)
  • [x] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [x] is descriptively named and links to an issue number, i.e. Fixes #123

catarak avatar Apr 28 '22 21:04 catarak

Release Environments

This pull request environment is provided by Release, learn more! To see the status of the environment click on Environment Status below.

:wrench:Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-c4a0807a28

release-com[bot] avatar Apr 28 '22 21:04 release-com[bot]

I upgraded react-helmet to its latest version, v6.1.0, and react-tabs to 3.2.3, which is the latest one compatible with our current version of React. I think https://github.com/processing/p5.js-web-editor/pull/2218 can address the remaining warnings for now.

raclim avatar Jul 18 '23 21:07 raclim

I upgraded react-helmet to its latest version, v6.1.0

Did that actually fix the warnings? My understanding is that react-helmet is dead and we need to switch to react-helmet-async.

lindapaiste avatar Sep 05 '23 17:09 lindapaiste

Some of these changes have fallen out of date, so I'm going to close this for now!

raclim avatar Sep 11 '23 12:09 raclim