p5.js-web-editor icon indicating copy to clipboard operation
p5.js-web-editor copied to clipboard

Bulk Sketch Download Feature (Fixes #1939)

Open dwight9339 opened this issue 3 years ago • 5 comments

Fixes #issue-number

I have verified that this pull request:

  • [x] has no linting errors (npm run lint)
  • [x] is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • [x] is descriptively named and links to an issue number, i.e. Fixes #123

dwight9339 avatar Feb 03 '22 00:02 dwight9339

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

welcome[bot] avatar Feb 03 '22 00:02 welcome[bot]

Release Environments

This pull request environment is provided by Release, learn more! To see the status of the environment click on Environment Status below.

:wrench:Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-fc99ae525e

release-com[bot] avatar Feb 03 '22 00:02 release-com[bot]

Here's my fix for issue #1939. It's able to combine all projects into a single zip file but we're going to need to do a serious refactor the bundleExternalLibs() function in project.controller.js if we want to add external dependency files to each project. I'm also not sure about the placement of the "Download all" button on the sketches page. Thanks

dwight9339 avatar Feb 03 '22 00:02 dwight9339

Managed to add external lib bundling to bundled project files without doing any major refactoring after all.

dwight9339 avatar Feb 12 '22 21:02 dwight9339

If there is anything I can do to help get this feature over the finish line, this is something I'd love to see. It is also similar to this PR about downloading collections as a zip: https://github.com/processing/p5.js-web-editor/pull/1997

NanoDano avatar Jul 03 '22 18:07 NanoDano

Hey @dwight9339, sorry for the delay in reviewing this!

Would you be interested in revisiting this again? I'd love to see your work on this come to fruition in the near future!

raclim avatar Jul 11 '23 18:07 raclim

I'm going to close this for now, but please feel free to rework this PR or create a new one regarding this feature!

raclim avatar Jul 17 '23 23:07 raclim