p5.js-web-editor
p5.js-web-editor copied to clipboard
[#1953] Separate Console and Editor font sizes
Split user.preferences.fontSize into .editor and .console
Fixes #1953
I have verified that this pull request:
- [x] has no linting errors (
npm run lint
) - [x] is from a uniquely-named feature branch and has been rebased on top of the latest
develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too) - [x] is descriptively named and links to an issue number, i.e.
Fixes #123
TODO:
- [ ] localization for font size settings
- [ ] UI updates?
I think there probably doesn't need to be so much UI space spent on the two separate sections, and it might be possible to put both forms in the same section, but I didn't see precedence for that.
I was also not able to find the process for filling out localization when adding new labels and titles, let me know what needs to be done there!
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.
Release Environments
This pull request environment is provided by Release, learn more! To see the status of the environment click on Environment Status below.
:wrench:Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-649cf05a5b
I just updated the tests for font size to use dispatch
through the reduxRender
function. Preferences
isn't itself connect
ed so I just patched setFontSize
through, and the integration doesn't quite get to confirming that state is updating and that Preferences
receives new props. I suppose Preferences
itself could be connect
ed and select the .preferences
state, but I wanted to check in with someone about whether that would be worthwhile.
Thank you so much for your efforts and for taking the time to contribute to this issue—I'm so sorry we couldn't get to your work in time! Since some time has passed I'm going to close this for now, but please feel free to reopen this or work on this again, thanks!