p5.js-web-editor
p5.js-web-editor copied to clipboard
Fix typos in translation
Fixes #1948
I have verified that this pull request:
- [X] is from a uniquely-named feature branch and has been rebased on top of the latest
develop
branch. (If I was asked to make more changes, I have made sure to rebase ontodevelop
then too) - [X] is descriptively named and links to an issue number, i.e.
Fixes #123
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.
Release Environments
This pull request environment is provided by Release, learn more! To see the status of the environment click on Environment Status below.
:wrench:Environment Status : https://app.releasehub.com/public/Processing%20Foundation/env-794aa730f2
@code4humanity it seems like some of the changes you made are fixing typos, and others are a little more major. Would it be possible to have another person who speaks Brazilian Portuguese to review these changes?
tagging @byfelipesanchez, who did the original translation, to weigh in.
@catarak, I agree. Most of them were fixing typos, I think the ones in line 60 and 297 were the major ones. Do you want me to remove them while we discuss the issue #1951?
I think because the changes suggested in #1951 are relatively small, we can leave this as it is.
Do you need help soliciting feedback from others?
@catarak, I'm sorry for the delay in my response.
I was thinking I could revert the changes that worries you and in #1951 I could finish reviewing the whole file and create a draft PR so we can discuss it as I believe there are more modifications than the ones I wrote. What do you think?
I was thinking I could revert the changes that worries you and in #1951 I could finish reviewing the whole file and create a draft PR so we can discuss it as I believe there are more modifications than the ones I wrote. What do you think?
Fine by me!