p5.js-sound
p5.js-sound copied to clipboard
(chore) : Added Headless Testing
Signed-off-by: Abhijay Jain [email protected]
refer PR: #641 (resolved merge conflicts in existing PR)
- Added mocha-chrome as a grunt task, which is borrowed from p5.js.
- Changed the test filing architecture and the initialization of expect in all test files so that all the files go to one spec array.
- Added karma-js as it seems more consistent with tests.
- We currently, cannot use it in GitHub automation as it is still not 100 % reliable. Some tests are still failing in some cases.
- We can add retry functionality to some tests which can be identified as failing and maybe one day in the future, we can add it to GitHub actions.
cc : @davepagurek , @satyasaibhushan review required.
Thanks for taking on this PR!
When I try to run npm install to get the new dependencies, I run into this error:

Is this also something you get or is it just me?
We currently, cannot use it in GitHub automation as it is still not 100 % reliable. Some tests are still failing in some cases.
Out of curiosity, how many test cases are failing? If it's a small enough amount, a great follow-up PR could comment them out for now, so that we get automated PR testing for most things, and then we can make some issues to fix the lingering tests. If it's a lot though, it sounds like we might need to solve some underlying issues first
Thanks for taking on this PR!
When I try to run
npm installto get the new dependencies, I run into this error:Is this also something you get or is it just me?
I faced similar issues while installing these packages, I uninstalled the mentioned packages and re-installed them using --force, maybe it is due to version incompatibly, I am not sure about it but will look into this :)
We currently, cannot use it in GitHub automation as it is still not 100 % reliable. Some tests are still failing in some cases.
Out of curiosity, how many test cases are failing? If it's a small enough amount, a great follow-up PR could comment them out for now, so that we get automated PR testing for most things, and then we can make some issues to fix the lingering tests. If it's a lot though, it sounds like we might need to solve some underlying issues first
@davepagurek 20 tests are falling in total :

We currently, cannot use it in GitHub automation as it is still not 100 % reliable. Some tests are still failing in some cases.
Out of curiosity, how many test cases are failing? If it's a small enough amount, a great follow-up PR could comment them out for now, so that we get automated PR testing for most things, and then we can make some issues to fix the lingering tests. If it's a lot though, it sounds like we might need to solve some underlying issues first
@davepagurek 20 tests are falling in total :
I will open a follow-up PR once we merge this one, commenting all those falling tests
@Abhijay007 Why did you open a new PR when you can add the changes needed to this old PR? Doing it this way will remove my original commits.
@Abhijay007 Why did you open a new PR when you can add the changes needed to this old PR? Doing it this way will remove my original commits.
@satyasaibhushan I didn't have the access to resolve the conflicts directly that's why I opened a new PR resolving the existing one, and I was not aware of the cherry-pick commits technique before, thanks for mentioning that, I will iterate the PR accordingly.