p5.js-sound icon indicating copy to clipboard operation
p5.js-sound copied to clipboard

(chore) : Added Headless Testing

Open Abhijay007 opened this issue 2 years ago • 8 comments

Signed-off-by: Abhijay Jain [email protected]

refer PR: #641 (resolved merge conflicts in existing PR)

  • Added mocha-chrome as a grunt task, which is borrowed from p5.js.
  • Changed the test filing architecture and the initialization of expect in all test files so that all the files go to one spec array.
  • Added karma-js as it seems more consistent with tests.
  • We currently, cannot use it in GitHub automation as it is still not 100 % reliable. Some tests are still failing in some cases.
  • We can add retry functionality to some tests which can be identified as failing and maybe one day in the future, we can add it to GitHub actions.

Abhijay007 avatar Jan 20 '23 18:01 Abhijay007

cc : @davepagurek , @satyasaibhushan review required.

Abhijay007 avatar Jan 26 '23 16:01 Abhijay007

Thanks for taking on this PR!

When I try to run npm install to get the new dependencies, I run into this error: image

Is this also something you get or is it just me?

davepagurek avatar Jan 28 '23 00:01 davepagurek

We currently, cannot use it in GitHub automation as it is still not 100 % reliable. Some tests are still failing in some cases.

Out of curiosity, how many test cases are failing? If it's a small enough amount, a great follow-up PR could comment them out for now, so that we get automated PR testing for most things, and then we can make some issues to fix the lingering tests. If it's a lot though, it sounds like we might need to solve some underlying issues first

davepagurek avatar Jan 28 '23 00:01 davepagurek

Thanks for taking on this PR!

When I try to run npm install to get the new dependencies, I run into this error: image

Is this also something you get or is it just me?

I faced similar issues while installing these packages, I uninstalled the mentioned packages and re-installed them using --force, maybe it is due to version incompatibly, I am not sure about it but will look into this :)

Abhijay007 avatar Jan 28 '23 14:01 Abhijay007

We currently, cannot use it in GitHub automation as it is still not 100 % reliable. Some tests are still failing in some cases.

Out of curiosity, how many test cases are failing? If it's a small enough amount, a great follow-up PR could comment them out for now, so that we get automated PR testing for most things, and then we can make some issues to fix the lingering tests. If it's a lot though, it sounds like we might need to solve some underlying issues first

@davepagurek 20 tests are falling in total :

image

Abhijay007 avatar Jan 28 '23 16:01 Abhijay007

We currently, cannot use it in GitHub automation as it is still not 100 % reliable. Some tests are still failing in some cases.

Out of curiosity, how many test cases are failing? If it's a small enough amount, a great follow-up PR could comment them out for now, so that we get automated PR testing for most things, and then we can make some issues to fix the lingering tests. If it's a lot though, it sounds like we might need to solve some underlying issues first

@davepagurek 20 tests are falling in total :

image

I will open a follow-up PR once we merge this one, commenting all those falling tests

Abhijay007 avatar Jan 28 '23 16:01 Abhijay007

@Abhijay007 Why did you open a new PR when you can add the changes needed to this old PR? Doing it this way will remove my original commits.

satyasaibhushan avatar Jan 30 '23 10:01 satyasaibhushan

@Abhijay007 Why did you open a new PR when you can add the changes needed to this old PR? Doing it this way will remove my original commits.

@satyasaibhushan I didn't have the access to resolve the conflicts directly that's why I opened a new PR resolving the existing one, and I was not aware of the cherry-pick commits technique before, thanks for mentioning that, I will iterate the PR accordingly.

Abhijay007 avatar Jan 30 '23 20:01 Abhijay007