p5.js-sound icon indicating copy to clipboard operation
p5.js-sound copied to clipboard

minified p5js-sound and minified p5js

Open outofambit opened this issue 7 years ago • 3 comments

Did any of y'all see https://github.com/processing/p5.js/issues/2920 ? Looks like there might be an issue with the minified p5js-sound distro? Not totally sure but wanted to make sure this was mentioned just in case!

outofambit avatar Jun 05 '18 18:06 outofambit

thanks for the issue! I'll comment there, because I'm not totally sure if I follow what the issue is, but I think this could be resolved by changing the main in p5.js package.json to use the .min.js, here, and by adding "main": "./lib/p5.sound.min.js" to p5.sound's package.json

therewasaguy avatar Jun 06 '18 03:06 therewasaguy

B/c the property "main" points to the default library within the NPM repo package, I can use this shorter CDN link: https://CDN.JsDelivr.net/npm/p5, in place of https://CDN.JsDelivr.net/npm/p5/lib/p5.min.js. :-)

GoToLoop avatar Jun 06 '18 10:06 GoToLoop

Hi all! I've opened a related issue in p5 (https://github.com/processing/p5.js/issues/4546) as the problem there still exists, and wanted to check in on this issue too since it's still open.

@therewasaguy I think adding "main": "./lib/p5.sound.min.js" to the package.json of this repo would only solve the issue if p5-sound was published as a separate npm package, and in that case it should have p5 as a dependency (if p5 itself exports a minified version).

As @Streemo said in another comment:

p5-sound should be a standalone NPM package with standard a standard dependency on p5.

neefrehman avatar May 13 '20 10:05 neefrehman