p5.accessibility icon indicating copy to clipboard operation
p5.accessibility copied to clipboard

rename some args

Open mithru opened this issue 6 years ago • 1 comments

Nature of issue

  • [x] Existing feature enhancement

I realized things like the below line from fillEntity.js use the name shapeObject which perhaps makes sense in shapeEntity.js but the meaning doesn't carry through for newer methods. Maybe we can rename it to methodObject ? I sure helps me understand the code a lot better.

function FillEntity(Interceptor, shapeObject, fillArgs, canvasX, canvasY) 

For reference, if I console.log(shapeObject) I get this

{name: "fill", params: Array(4), class: "p5", module: "Color", submodule: "Setting"}

Thoughts?

mithru avatar Sep 30 '18 02:09 mithru

I can do this, if we decide to make this change. Regardless, I'm using methodObject on newer entities that I implement.

mithru avatar Sep 30 '18 02:09 mithru