bpmn-visualization-js icon indicating copy to clipboard operation
bpmn-visualization-js copied to clipboard

[FEAT] Apply various Activity Markers improvements

Open tbouffard opened this issue 6 months ago • 0 comments

Is your feature request related to a problem? Please describe.

Several improvements are required to improve the rendering of the markers, in particular to implement new features.

This issue is providing a centralized place to track the improvements globally.

Describe the solution you'd like

### Related features
- [ ] #465
- [ ] #475
- [ ] #992
### Details
- [ ] enforce marker width + review width value: value `12`, see https://github.com/process-analytics/bpmn-visualization-js/pull/2724#issuecomment-2004574370
- [ ] marker stroke width: value `1`, see https://github.com/process-analytics/bpmn-visualization-js/pull/2724#issuecomment-2004574370
- [ ] center maker vertically
- [ ] markers spacing: value `4`, see https://github.com/process-analytics/bpmn-visualization-js/pull/2724#issuecomment-2004574370
- [x] marker bottom margin: remain unchanged, to not overlap the lines of the Transaction Sub-Process
- [ ] loop marker: reduce width and keep the existing design
- [ ] **Refactoring including breaking changes** - rename StyleDefault elements: including the margin bottom, no need to include ICON in the name if we use MARKER. All names should be review (for example, there is no need to prefix them by DEFAULT, these are properties of an object name StyleDefault, so the "default" purpose is already included).
- [ ] **Refactoring including breaking changes** - update values in ShapeBpmnMarkerKind with values used in #2724 --> #3147
- [ ] Enrich the BPMN diagram used for visual tests (more usage of compensation) to prepare next developments. Use diagram updated in #2724 + ensure that visual tests include digram for collapsed adhoc subprocess with a compensation marker
- [x] Refactor BaseActivityShape.paintMarkerIcons. Remove switch and use a Map, as done in #2724 --> #3147
- [ ] Review all refactoring provided in #2724 and ensure that they are implemented

Additional context

The tasks mentioned are based on decision taken on 2024-04-04 in #2724. The elements mentioned here are prerequisites for

  • #355
  • #356

tbouffard avatar Aug 16 '24 15:08 tbouffard