smee.io icon indicating copy to clipboard operation
smee.io copied to clipboard

Check if escape sequences are handled correctly

Open gr2m opened this issue 6 years ago • 2 comments

This is a follow up for https://github.com/octokit/webhooks.js/issues/71. It would be good to check if smee is lowercasing escape sequences before forward a webhook event.

gr2m avatar Apr 09 '19 20:04 gr2m

I think it is a bug doing any type of transformation. The payload should not be touched or any signature calculation from github could break as I mentioned here https://github.com/octokit/webhooks.js/issues/71#issuecomment-481430219

gimenete avatar Apr 09 '19 20:04 gimenete

No intended transformation is done, but given that it’s happening with JSON.parse() I want to make sure that smee is not affected

gr2m avatar Apr 09 '19 22:04 gr2m