linuxdeployqt icon indicating copy to clipboard operation
linuxdeployqt copied to clipboard

Published 20 hours ago • verified publisher icon probonopd

Non-master branch builds create new releases

Open TheAssassin opened this issue 6 years ago • 5 comments

This should be fixed asap. Only master builds should create new releases on GitHub.

I guess a simple if clause in the Travis config checking the branch name before the upload part should do.

TheAssassin avatar Jan 26 '18 08:01 TheAssassin

CC @probonopd.

TheAssassin avatar Jan 26 '18 08:01 TheAssassin

Agree this should be changed. I think this is an issue for https://github.com/probonopd/uploadtool, plese open a ticket there or ideally send a PR. Thanks.

probonopd avatar Jan 28 '18 09:01 probonopd

Current workaround: https://github.com/AppImage/AppImageUpdate/blob/rewrite/.travis.yml#L17

TheAssassin avatar Jan 28 '18 10:01 TheAssassin

I merged a quick fix based on how I solved the issue in AppImageUpdate, so we can assume this is no longer a high priority issue. If anyone's interested in fixing this upstream, please develop a patch for uploadtool and create a PR there, thanks.

TheAssassin avatar Jan 29 '18 14:01 TheAssassin

This is the cause why builds for releases are not uploaded to GitHub Releases, causing https://github.com/probonopd/linuxdeployqt/issues/322#issuecomment-431664510.

probonopd avatar Oct 21 '18 12:10 probonopd