go-appimage icon indicating copy to clipboard operation
go-appimage copied to clipboard

Also generate updateinformation for GitHub Actions, GitHub Workflows

Open probonopd opened this issue 5 years ago • 8 comments

The presence of the env GITHUB_WORKFLOW signals that we are running in a GitHub Action. We should do some automatic similar to what we are doing for Travis CI.

https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables

probonopd avatar Aug 16 '20 07:08 probonopd

GitHub automatically creates a GITHUB_TOKEN secret to use in your workflow. You can use the GITHUB_TOKEN to authenticate in a workflow run.

https://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token

probonopd avatar Aug 16 '20 08:08 probonopd

Example: https://github.com/probonopd/Akira/actions

probonopd avatar Aug 16 '20 08:08 probonopd

In order to generate updateinformation, we would probably have to internalize what

    - name: Release AppImage
      uses: marvinpinto/action-automatic-releases@latest
      with:
        title: AppImage
        automatic_release_tag: continuous
        prerelease: true
        draft: false
        files: |
          Akira*.AppImage*
        repo_token: ${{ secrets.GITHUB_TOKEN }}

does so that we can be sure that the resulting AppImages are uploaded to the proper location.

Blocked by: https://github.com/marvinpinto/actions/issues/40

Or, it would be neat if we could parse the above yml from within appimagetool and hence know the value of automatic_release_tag...

probonopd avatar Aug 16 '20 09:08 probonopd

Work started in https://github.com/probonopd/go-appimage/commit/7fab45552eb485c0076fd310835fa7958f981de0

Currently it produces wrong update information for continuous builds:

[manjaro@manjaro ~]$ Downloads/altairsim-26-x86_64.AppImage --appimage-updateinformation
gh-releases-zsync|probonopd|altairsim.AppImage|latest|altairsim-*-x86_64.AppImage.zsync

Here, it would need to be continuous rather than latest...

probonopd avatar Aug 24 '20 18:08 probonopd

We should probably also remove support for Travis CI...

probonopd avatar May 07 '22 13:05 probonopd

Is there a way to generate a .zsync file using the static lib builds?

The AppImage was created, but is lacking update information.
Possibly it was built on a local developer machine.
Such an AppImage is fine for local use but should not be distributed.
Please build on one of the supported CI systems like Travis CI
if you want your AppImage to be updatable
and have update notifications published.

I receive the following message when building with GITHUB ACTIONS passing the -u flag. Trying locally, updateinformation= and -u flag both fail with similar messages. zsyncmake is in $PATH, embedded in usr/bin, and in the running directory but fails to find it.

Tested with: mkappimage-709-x86_64.AppImage and appimagetool-709-x86_64.AppImage

Using linuxdeploy, linuxdeployqt and appimagetool (non-go) produce the file, but I want to transition to libfuse embedded for Ubuntu 22.04.

qurious-pixel avatar May 30 '22 13:05 qurious-pixel

Work started in https://github.com/probonopd/go-appimage/commit/7fab45552eb485c0076fd310835fa7958f981de0

You need to use appimagetool (NOT mkappimage), do not need -u, and iirc i should automagically guess the correct update information. It's been a while since I had looked at this, though.

Does that work better?

(mkappimage was made for use by other tools that need a low level tool - that's not me...)

probonopd avatar May 30 '22 21:05 probonopd

Here, it would need to be continuous rather than latest...

Sounds similar to

I am also using the continuous tag, but it applied the latest tag.

in https://github.com/probonopd/static-tools/issues/32#issuecomment-1151471090 - so this is still wrong.

probonopd avatar Jun 09 '22 18:06 probonopd