go-appimage icon indicating copy to clipboard operation
go-appimage copied to clipboard

Published 20 hours ago • verified publisher icon probonopd

addimaged likes to connect out to the internet for no apparent reason.

Open majestrate opened this issue 3 years ago • 5 comments

according to the source this program likes to connect out on plaintext to some server on aws.

https://github.com/probonopd/go-appimage/blob/d1d2094ae63ec632bb204c83be62b38af48fdbfd/internal/helpers/mqtt.go#L76

can this be hidden behind an opt in analytics build tag? or does this do something else entirely?

majestrate avatar Mar 03 '21 00:03 majestrate

This is an experimental feature to notify the user about available updates of AppImages. It should probably be deactivated from builds that are used for anything but experimentation.

probonopd avatar Mar 03 '21 19:03 probonopd

i see, perhaps consider hiding such things behind a build tag, e.g. // +build experimental so that if someone using production builds doesn't have potential bugs introduced by these experimental features.

majestrate avatar Mar 05 '21 11:03 majestrate

Indeed this would be an useful option. Do you know how to implement it?

probonopd avatar Mar 05 '21 17:03 probonopd

yes, using golang's build tags, see https://www.digitalocean.com/community/tutorials/customizing-go-binaries-with-build-tags

majestrate avatar Mar 05 '21 18:03 majestrate

On a machine that's not connected to the internet at all times, this produces a flood of log entries.

Sep 05 09:15:24 xyz appimaged[2544]: 2022/09/05 09:15:24 MQTT client connected: false Sep 05 09:15:24 xyz appimaged[2544]: 2022/09/05 09:15:24 MQTT client connected: false Sep 05 09:13:24 xyz appimaged[2544]: 2022/09/05 09:13:24 MQTT client connected: false Sep 05 09:13:24 xyz appimaged[2544]: 2022/09/05 09:13:24 MQTT client connected: false Sep 05 09:11:24 xyz appimaged[2544]: 2022/09/05 09:11:24 MQTT client connected: false Sep 05 09:11:24 xyz appimaged[2544]: 2022/09/05 09:11:24 MQTT client connected: false Sep 05 09:09:24 xyz appimaged[2544]: 2022/09/05 09:09:24 MQTT client connected: false Sep 05 09:09:24 xyz appimaged[2544]: 2022/09/05 09:09:24 MQTT client connected: false Sep 05 09:07:24 xyz appimaged[2544]: 2022/09/05 09:07:24 MQTT client connected: false Sep 05 09:07:24 xyz appimaged[2544]: 2022/09/05 09:07:24 MQTT client connected: false Sep 05 09:05:24 xyz appimaged[2544]: 2022/09/05 09:05:24 MQTT client connected: false Sep 05 09:05:24 xyz appimaged[2544]: 2022/09/05 09:05:24 MQTT client connected: false Sep 05 09:03:24 xyz appimaged[2544]: 2022/09/05 09:03:24 MQTT client connected: false Sep 05 09:03:24 xyz appimaged[2544]: 2022/09/05 09:03:24 MQTT client connected: false Sep 05 09:01:24 xyz appimaged[2544]: 2022/09/05 09:01:24 MQTT client connected: false Sep 05 09:01:24 xyz appimaged[2544]: 2022/09/05 09:01:24 MQTT client connected: false Sep 05 08:59:24 xyz appimaged[2544]: 2022/09/05 08:59:24 MQTT client connected: false Sep 05 08:59:24 xyz appimaged[2544]: 2022/09/05 08:59:24 MQTT client connected: false

dafi87 avatar Sep 05 '22 08:09 dafi87