pmtk3 icon indicating copy to clipboard operation
pmtk3 copied to clipboard

normalise function is not a part of pmtk, may be we have to use normalize one instead

Open ido opened this issue 11 years ago • 1 comments

From RA.Dragun on August 28, 2011 03:56:00

What steps will reproduce the problem? 1.Some functionality that uses function path = viterbi_path(prior, transmat, obslik) What is the expected output? What do you see instead? What version / revision of the product are you using? On what operating system? pmtk r2776 Please provide any additional information below. Replace normalise function with normalize one on lines: 53, 64 http://code.google.com/p/pmtk3/source/browse/trunk/toolbox/LatentVariableModels/hmm/sub/viterbi_path.m#53

Original issue: http://code.google.com/p/pmtk3/issues/detail?id=32

ido avatar Jan 04 '14 01:01 ido

From [email protected] on June 29, 2012 02:54:58

I also experienced this same problem. I don't know if there is a separate normalise.m file that is needed, or if changing these lines to "normalize" correctly solves the problem. What is more interesting is that this (possible) bug causes the testPmtk3 to fail:

??? Undefined function or method 'normalise' for input arguments of type 'double'.

Error in ==> viterbi_path at 53 [delta(:,t), n] = normalise(delta(:,t));

Error in ==> hmmMap at 22 path = viterbi_path(pi, A, exp(logB));

Error in ==> hmmDiscreteTest at 38 decodedFromTrueViterbi = hmmMap(trueModel, observed);

Error in ==> testPmtk3 at 68 hmmDiscreteTest;

ido avatar Jan 04 '14 01:01 ido