Parameters are not set in condDiscreteProdCpdFit

Open flokadillo opened this issue 9 years ago • 1 comments

There seems to be a small error in GraphicalModels/cpd/condDiscreteProdCpdCreate.m. In function condDiscreteProdCpdFit, the variable T is computed but is not returned. I guess we should add a line saying CPD.T = T; to the end of the function.

Jan 30 '17 12:01 flokadillo

Please make a pull request with the bug fix.

On Mon, Jan 30, 2017 at 4:56 AM, flokadillo [email protected] wrote:

There seems to be a small error in GraphicalModels/cpd/ condDiscreteProdCpdCreate.m. In function condDiscreteProdCpdFit, the variable T is computed but is not returned. I guess we should add a line saying CPD.T = T; to the end of the function.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/probml/pmtk3/issues/128, or mute the thread https://github.com/notifications/unsubscribe-auth/AEavEFyEWJcSQGfYWtdHu156DoMMvGZlks5rXd3-gaJpZM4LxXuT .

Jan 31 '17 06:01 murphyk