Christian Schwarz
Christian Schwarz
As a rule of thumb, it's better to use mountpoint=none on the receiving side to prevent the receiving side filesystem from getting dirtied by the implicit mkdir that ZFS needs...
https://github.com/zrepl/zrepl/pull/831
@mjasnik I would appreciate a review. You got an invite as a read-only collaborator. IIUC that should be sufficient for posting reviews.
Regarding the disallowed characters in snapshot names, > like "/|$#", maybe reimplementing the [`snapshot_namecheck`](https://github.com/openzfs/zfs/blob/1d3ba0bf01020f5459b1c28db3979129088924c0/module/zcommon/zfs_namecheck.c#L334-L351) function in Go would be the better way. Then, we could fail config parsing if the...
Also, have you tried this PR for your use case?
It seems you're implying that the current state of this PR would fail more at runtime than your original PR? If so, would love for a pointer to that code,...
@Mjasnik I added the config-parsing-time check for all invalid characters. I think this is good to merge, would be happy if you could test it.
Thanks for testing!
I remain irritated by the CI logs now showing `=SidecarTask`. Asked devprod team on Slack: https://neondb.slack.com/archives/C059ZC138NR/p1737490501941309
This epic is complete as of this week's storage deploy. https://neondb.slack.com/archives/C03H1K0PGKH/p1722347077872989?thread_ts=1722244979.635389&cid=C03H1K0PGKH