cargo-flash icon indicating copy to clipboard operation
cargo-flash copied to clipboard

Chip field in manifest metadata unused when building flash loader

Open tmplt opened this issue 2 years ago • 2 comments

I'm refactoring some common functionality from cargo-flash into probe-rs-cli-util and noticed that the package.metadata.chip from the firmware manifest is only written to METADATA if found. When building the flash loader, only --chip is used.

Below displays the full scope-usage of chip:

https://github.com/probe-rs/cargo-flash/blob/0615fd5519c80cd1a7379745230798765978f1fa/src/main.rs#L360-L367

And when the flash loader is built:

https://github.com/probe-rs/cargo-flash/blob/0615fd5519c80cd1a7379745230798765978f1fa/src/main.rs#L414-L426

I presume this is a regression from #31?

tmplt avatar Jul 05 '21 07:07 tmplt

When #188 merges this issue moves upstream to probe-rs-cli-util::common_options.

tmplt avatar Jul 29 '21 23:07 tmplt

@Tiwalun what do you think, should we implement this in probe-rs-cli-util or just in cargo-flash?

Yatekii avatar Jan 29 '22 01:01 Yatekii