probnum icon indicating copy to clipboard operation
probnum copied to clipboard

Best practice for `# TODO` comments

Open marvinpfoertner opened this issue 5 years ago • 3 comments

As discussed with @JonathanWenger, we should allow # TODO comments in the codebase, but only in a well-defined format. I propose to only allow them if they are formatted as # TODO: (#1234) Description of what needs to be done, where #1234 is a GitHub issue number. This should also be added to the project documentation.

marvinpfoertner avatar Aug 30 '20 15:08 marvinpfoertner

Any thoughts? @JonathanWenger @pnkraemer @nathanaelbosch

marvinpfoertner avatar Aug 30 '20 15:08 marvinpfoertner

Sounds good to me! I still think they can and should be avoided in many cases, but for the cases where they are useful they should definitely follow some well-defined format. I think the idea with the GitHub issue number is really good :)

nathanaelbosch avatar Aug 30 '20 17:08 nathanaelbosch

I agree wholeheartedly with @nathanaelbosch ;)

pnkraemer avatar Aug 31 '20 08:08 pnkraemer