pro-wh

We have a ledger.ts file in this repo that does several of the same things: - implement ContextSigner - throw when returned status is abnormal - set up a key...

inputs: add labels

1

right now we have several places where they rely only on placeholder text. placeholder text disappears once you enter something, so it's harder to review a form once it's filled

switch to entering gas price instead of total fee

1

people probably are more used to doing it that way.

allow submitting a transaction even if local balance check fails

1

> This should do. One suggestion though: add a popup that says "submit this transaction anyway" instead of forcing people to accept the local sanity check. That local check introduces...

red button for copy private key

1

we had once done this hacky thing of swapping the confirm and cancel buttons for certain risky actions, but now we have more technology for coloring things red (e.g. for...

instructions for packaging for Firefox

2

Heads up: For Firefox you'll need `(cd dist && zip --recurse-paths ../oasis-wallet-$VERSION.zip ./)` And it should work for Chrome too _Originally posted by @lukaw3d in https://github.com/oasisprotocol/oasis-wallet-ext/pull/193#discussion_r773224041_

eliminate password trim

1

opinion: allow whitespace at the ends of passwords > All of them :D _Originally posted by @lukaw3d in https://github.com/oasisprotocol/oasis-wallet-ext/issues/178#issuecomment-996018698_

rewrite async code

1

For our preferred style, we'd like to adjust the style of async code: - switch to async/await, avoid lower level `new Promise`/`resolve`+`reject` where possible - errors should be `throw`n/passed to...

build params strings with URLSearchParams

1

A nicer alternative ``` './popup.html#/request_sign?' + new URLSearchParams({isUnlocked, siteUrl, context, message, address, siteIcon: icon}).toString() ``` _Originally posted by @lukaw3d in https://github.com/oasisprotocol/oasis-wallet-ext/pull/67#discussion_r694201803_

transaction confirmation popup: params--message synchronization

3

https://github.com/oasisprotocol/oasis-wallet-ext/blob/f912f132cc22bec5d70541ddf46b90d7d28c6c6d/src/background/service/ExtDappService.js#L215 the signature request 'message' is sent over popup url parameters, but the parsed parameters are requested over the message bus, which retrieves it from the top of a queue....