soundsense-rs icon indicating copy to clipboard operation
soundsense-rs copied to clipboard

Implement packaging on release, so MacOS and Linux users can use it out of the box.

Open prixt opened this issue 5 years ago • 9 comments

As the title says.

prixt avatar Feb 17 '20 08:02 prixt

I tried making a package, but it didn't work. You can include this script for now, though:

#!/bin/sh
dir=${0%/*}
if [ -d "$dir" ]; then
 cd "$dir"
fi
chmod +x soundsense-rs-v1.4.4-alpha4-osx
./soundsense-rs-v1.4.4-alpha4-osx

Use the extension ".command" on the script file. Users will need to right-click (or control-click) on the script and select "open". Be sure to change the two instances of "soundsense-rs-v1.4.4-alpha4-osx" to match the name of the included executable.

This script might work in Linux too.

jecowa avatar Feb 17 '20 10:02 jecowa

How are you planning on adding soundsense-rs to the Mac Starter Package?

prixt avatar Feb 18 '20 02:02 prixt

It's already in. It launches from a script similar to this. The Mac version of Dwarf Fortress doesn't have packaging either; it uses a shell script too.

jecowa avatar Feb 18 '20 05:02 jecowa

https://github.com/prixt/soundsense-rs/releases/tag/v1.4.4-bundle hi @jecowa I'm trying to manually create .app bundles using the macos binaries. Could you test this?

prixt avatar Feb 19 '20 13:02 prixt

Attempt 1 had the same result as the one I tried to make: it doesn't run and says it requires macOS 10.15 or later. (I'm running 10.14.)

I don't have 10.15 Catalina to test on, but from past experience since there's no reason it shouldn't run on my computer, I would guess a Catalina user would get a different error saying it can't run it.

jecowa avatar Feb 20 '20 00:02 jecowa

Uploaded Attempt 2, added LSMinimumSystemVersion key to Info.plist.

prixt avatar Feb 20 '20 00:02 prixt

attempt2 is the same.

jecowa avatar Feb 20 '20 01:02 jecowa

also the two packaged versions are blurry on Retina displays. which is weird since it's identical to 1.4.4. If I move it out of the package, it runs with Retina support.

jecowa avatar Feb 20 '20 01:02 jecowa

To get the icon to work, delete

    <key>CFBundleIconName</key>
    <string>icon</string>

and change

    <key>CFBundleIconFile</key>
    <string>icon</string>

to

    <key>CFBundleIconFile</key>
    <string>icon.icns</string>

jecowa avatar Feb 20 '20 01:02 jecowa