soundsense-rs icon indicating copy to clipboard operation
soundsense-rs copied to clipboard

Fixed the external.invoke (fix #19)

Open pierredavidbelanger opened this issue 2 years ago • 5 comments

pierredavidbelanger avatar Dec 17 '22 03:12 pierredavidbelanger

Seems like maybe you hardcoded it to use Linux files and now it breaks on Windows.

Erquint avatar Dec 17 '22 10:12 Erquint

I do not understand what is OS specific in my commits.

I only replaced some javascript call using a solution I found here

Ill try something else

pierredavidbelanger avatar Dec 17 '22 15:12 pierredavidbelanger

The last commit implements this solution here

pierredavidbelanger avatar Dec 17 '22 15:12 pierredavidbelanger

Sorry, I'm preoccupied by trying to make a maintained fork of this here repo. Can't tell I'll be able to go all the way through with it. But I recreated your PR there in a cruddy way and building with it resulted in window.webkit evaluating to null on every slider drag callback. Haven't gotten very hands-on with it yet. I'll pay better attention when I figure out how to improve the build system first.

Erquint avatar Dec 18 '22 15:12 Erquint

did you tried this last commit also ?

Anyways, I feel the portable solution is somewhere in that direction.

I do not have access to an OSX nor Windows environement, so ill leave this PR as is for the maintainer to do whatever he wants with it.

Someone will poke me if they need help I guess.

Meanwhile It works good enough for me to continue my DF game ;)

pierredavidbelanger avatar Dec 18 '22 16:12 pierredavidbelanger