spree_slider icon indicating copy to clipboard operation
spree_slider copied to clipboard

FlexSlider2 support feature

Open thezed opened this issue 12 years ago • 15 comments

I found that Nivo and Anything sliders are not responsible for window resizing and it would be great for this gem to support some such as FlexSlider2.

BTW Good job with the gem, keep it going

thezed avatar Dec 13 '12 14:12 thezed

I think this extension should move away from supporting multiple carousel libraries, and just promote rolling your own as referenced in the README.

JDutil avatar Dec 18 '13 17:12 JDutil

Same - I think it should just support rolling your own.

joshuapaling avatar Sep 23 '14 00:09 joshuapaling

@priviterag this extension may be useful over at github.com/spree-contrib see my blog post http://spreecommerce.com/blog/the-state-of-extensions-2014 although I may be biased for using this in my website.

JDutil avatar Sep 23 '14 04:09 JDutil

Yeah I think a slider plugin is a pretty common requirement. I think this'd be good in spree-contrib

joshuapaling avatar Sep 25 '14 11:09 joshuapaling

Hi guys,

I'm glad to see that you find it useful. I need to find some spare time to publish it on spree-contrib or, if you have time, please, send me a pull request with the changes required and I'll merge it.

Kind regards, Giuseppe

On Thu, Sep 25, 2014 at 1:50 PM, Joshua Paling [email protected] wrote:

Yeah I think a slider plugin is a pretty common requirement. I think this'd be good in spree-contrib

— Reply to this email directly or view it on GitHub https://github.com/priviterag/spree_slider/issues/12#issuecomment-56807651 .

priviterag avatar Sep 25 '14 11:09 priviterag

@JDutil Your blog post doesn't actually say who to contact in order to get a project on spree-contrib. But if it does get added, it could be worth adding this fork: https://github.com/zewelor/spree_slider which has a couple of extra commits worth including.

joshuapaling avatar Sep 25 '14 12:09 joshuapaling

@priviterag you should be able to simply transfer the repo, and I can add you as a contributor. Github automatically sets up redirects, and allows people to continue bundling even without updating their Gemfiles.

JDutil avatar Sep 25 '14 15:09 JDutil

@JDutil tried to transfer to spree-contrib. it seems I need administrative access to the organisation to do it

priviterag avatar Sep 28 '14 17:09 priviterag

Odd I thought it worked for someone else, but maybe I just created them a repo and had them push to it. If you want to add me as an admin to this repo I could do it or we could just create a repo for you to push to, but that wouldn't setup github redirects...

JDutil avatar Sep 29 '14 21:09 JDutil

@priviterag Any chance you could add @JDutil as an admin, and we can transfer this over to spree-contrib? Otherwise, @JDutil could you just fork this repo, and we'll do without the redirects?

joshuapaling avatar Oct 07 '14 09:10 joshuapaling

@joshuapaling @JDutil seems good. going to add jdutil

priviterag avatar Oct 07 '14 10:10 priviterag

Thanks! And thanks for this plugin, it's great.

joshuapaling avatar Oct 07 '14 10:10 joshuapaling

@joshuapaling I cannot add @JDutil as administrator. not sure if it will work. let me know guys!

priviterag avatar Oct 07 '14 10:10 priviterag

@priviterag I've created https://github.com/spree-contrib/spree_slider and added you as a committer. If there is anyone else that should be added to the repo let me know.

JDutil avatar Oct 07 '14 21:10 JDutil

@JDutil Thanks Jeff!

priviterag avatar Oct 08 '14 06:10 priviterag