tsx icon indicating copy to clipboard operation
tsx copied to clipboard

Published 20 hours ago • verified publisher icon privatenumber

feat: support additional watchlist

Open boxizen opened this issue 1 year ago • 5 comments

closes #181

This change adds additional files to the watchlist via adding the add parameter.

boxizen avatar Mar 22 '23 16:03 boxizen

Thanks for the PR. Can you add a test?

privatenumber avatar Mar 22 '23 22:03 privatenumber

This workaround worked pretty good for me

nodemon --watch ./src --ext ts,graphql,json -x 'node --loader tsx src/main.ts'

rgigger avatar Sep 15 '23 21:09 rgigger

@privatenumber, Is this likely to be merged? It looks like your comments were addressed.

jbhurruth avatar Jan 26 '24 13:01 jbhurruth

Hey @privatenumber! What is the status of this one? Looks like there are no blockers to merge this one 🙏

itaikeren avatar Feb 14 '24 17:02 itaikeren

Sorry but unless this request is coming from a sponsor, this project is just something I work on for fun when I have a few min to spare, and I haven't had time to review this again. Hope to revisit in a few weeks when I wrap up my current project.

privatenumber avatar Feb 15 '24 02:02 privatenumber

Why was this closed? Was there a concern with the content or some other reason? (It does say "PR welcome" in https://github.com/privatenumber/tsx/issues/181)

I was about to open a new one for this feature (https://github.com/privatenumber/tsx/compare/master...zommerfelds:tsx:master), but then I noticed this existed already.

zommerfelds avatar May 20 '24 20:05 zommerfelds

When I changed the default branch on the repo, it unexpectedly closed all PRs. Feel free to re-open.

privatenumber avatar May 21 '24 00:05 privatenumber

@boxizen are you interested in changing this PR to point to the master branch and re-opening? I think this looks pretty much ready to be merged. I tried to create a separate PR but didn't have access.

zommerfelds avatar May 22 '24 06:05 zommerfelds

@boxizen are you interested in changing this PR to point to the master branch and re-opening? I think this looks pretty much ready to be merged. I tried to create a separate PR but didn't have access.

Of course, I'd be happy to do that. https://github.com/privatenumber/tsx/pull/561

boxizen avatar May 25 '24 03:05 boxizen